You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2016/02/23 01:10:57 UTC
[5/5] incubator-kudu git commit: Manually remove remaining .Pass()
calls
Manually remove remaining .Pass() calls
In all of the remaining usages of Pass(), the value being
passed was already in a rvalue context, so we could remove
the call.
Change-Id: Iff601dd14d016d2d76d43a68b330b3f55f78f99f
Reviewed-on: http://gerrit.cloudera.org:8080/2247
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/c9a20d01
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/c9a20d01
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/c9a20d01
Branch: refs/heads/master
Commit: c9a20d01382fc9920116c85178e27ce69bf5609a
Parents: d0a02cd
Author: Todd Lipcon <to...@apache.org>
Authored: Thu Feb 18 21:38:00 2016 -0800
Committer: Todd Lipcon <to...@apache.org>
Committed: Tue Feb 23 00:10:17 2016 +0000
----------------------------------------------------------------------
docs/design-docs/cpp-client.md | 4 ++--
src/kudu/consensus/raft_consensus_quorum-test.cc | 4 +---
src/kudu/rpc/inbound_call.cc | 2 +-
src/kudu/tablet/tablet_peer-test.cc | 4 ++--
src/kudu/tserver/remote_bootstrap_session-test.cc | 2 +-
src/kudu/tserver/tablet_service.cc | 4 ++--
src/kudu/util/debug/trace_event_impl.cc | 2 +-
7 files changed, 10 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/c9a20d01/docs/design-docs/cpp-client.md
----------------------------------------------------------------------
diff --git a/docs/design-docs/cpp-client.md b/docs/design-docs/cpp-client.md
index f7623d1..e199adb 100644
--- a/docs/design-docs/cpp-client.md
+++ b/docs/design-docs/cpp-client.md
@@ -44,13 +44,13 @@ void ExplicitBatchingExample() {
// Insert 100 rows.
for (int i = 0; i < 100; i++) {
- gscoped_ptr<Insert> ins = t->NewInsert();
+ Insert* ins = t->NewInsert();
ins->mutable_row()->SetInt64("key", i);
ins->mutable_row()->SetInt64("val", i * 2);
// The insert should return immediately after moving the insert
// into the appropriate buffers. This always returns OK unless the
// Insert itself is invalid (eg missing a key column).
- CHECK_OK(session->Apply(ins.Pass()));
+ CHECK_OK(session->Apply(ins));
}
// Update a row.
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/c9a20d01/src/kudu/consensus/raft_consensus_quorum-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/raft_consensus_quorum-test.cc b/src/kudu/consensus/raft_consensus_quorum-test.cc
index edc66fa..b8bd786 100644
--- a/src/kudu/consensus/raft_consensus_quorum-test.cc
+++ b/src/kudu/consensus/raft_consensus_quorum-test.cc
@@ -138,10 +138,8 @@ class RaftConsensusQuorumTest : public KuduTest {
}
void BuildPeers() {
- vector<LocalTestPeerProxyFactory*> proxy_factories;
for (int i = 0; i < config_.peers_size(); i++) {
auto proxy_factory = new LocalTestPeerProxyFactory(peers_.get());
- proxy_factories.push_back(proxy_factory);
auto txn_factory = new TestTransactionFactory(logs_[i].get());
@@ -173,7 +171,7 @@ class RaftConsensusQuorumTest : public KuduTest {
scoped_refptr<RaftConsensus> peer(
new RaftConsensus(options_,
std::move(cmeta),
- gscoped_ptr<PeerProxyFactory>(proxy_factory).Pass(),
+ gscoped_ptr<PeerProxyFactory>(proxy_factory),
std::move(queue),
std::move(peer_manager),
std::move(thread_pool),
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/c9a20d01/src/kudu/rpc/inbound_call.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/inbound_call.cc b/src/kudu/rpc/inbound_call.cc
index bcef576..6ba184d 100644
--- a/src/kudu/rpc/inbound_call.cc
+++ b/src/kudu/rpc/inbound_call.cc
@@ -125,7 +125,7 @@ void InboundCall::Respond(const MessageLite& response,
TRACE_TO(trace_, "Queueing $0 response", is_success ? "success" : "failure");
LogTrace();
- conn_->QueueResponseForCall(gscoped_ptr<InboundCall>(this).Pass());
+ conn_->QueueResponseForCall(gscoped_ptr<InboundCall>(this));
}
Status InboundCall::SerializeResponseBuffer(const MessageLite& response,
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/c9a20d01/src/kudu/tablet/tablet_peer-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet_peer-test.cc b/src/kudu/tablet/tablet_peer-test.cc
index 915c7bc..62211a1 100644
--- a/src/kudu/tablet/tablet_peer-test.cc
+++ b/src/kudu/tablet/tablet_peer-test.cc
@@ -192,7 +192,7 @@ class TabletPeerTest : public KuduTabletTest {
CountDownLatch rpc_latch(1);
tx_state->set_completion_callback(gscoped_ptr<TransactionCompletionCallback>(
- new LatchTransactionCompletionCallback<WriteResponsePB>(&rpc_latch, resp.get())).Pass());
+ new LatchTransactionCompletionCallback<WriteResponsePB>(&rpc_latch, resp.get())));
CHECK_OK(tablet_peer->SubmitWrite(tx_state));
rpc_latch.Wait();
@@ -460,7 +460,7 @@ TEST_F(TabletPeerTest, TestActiveTransactionPreventsLogGC) {
auto tx_state = new WriteTransactionState(tablet_peer_.get(), req.get(), resp.get());
tx_state->set_completion_callback(gscoped_ptr<TransactionCompletionCallback>(
- new LatchTransactionCompletionCallback<WriteResponsePB>(&rpc_latch, resp.get())).Pass());
+ new LatchTransactionCompletionCallback<WriteResponsePB>(&rpc_latch, resp.get())));
gscoped_ptr<DelayedApplyTransaction> transaction(new DelayedApplyTransaction(&apply_started,
&apply_continue,
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/c9a20d01/src/kudu/tserver/remote_bootstrap_session-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tserver/remote_bootstrap_session-test.cc b/src/kudu/tserver/remote_bootstrap_session-test.cc
index 04b876b..b09dd6f 100644
--- a/src/kudu/tserver/remote_bootstrap_session-test.cc
+++ b/src/kudu/tserver/remote_bootstrap_session-test.cc
@@ -162,7 +162,7 @@ class RemoteBootstrapTest : public KuduTabletTest {
auto state = new WriteTransactionState(tablet_peer_.get(), &req, &resp);
state->set_completion_callback(gscoped_ptr<tablet::TransactionCompletionCallback>(
- new tablet::LatchTransactionCompletionCallback<WriteResponsePB>(&latch, &resp)).Pass());
+ new tablet::LatchTransactionCompletionCallback<WriteResponsePB>(&latch, &resp)));
ASSERT_OK(tablet_peer_->SubmitWrite(state));
latch.Wait();
ASSERT_FALSE(resp.has_error()) << "Request failed: " << resp.error().ShortDebugString();
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/c9a20d01/src/kudu/tserver/tablet_service.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tserver/tablet_service.cc b/src/kudu/tserver/tablet_service.cc
index 231b26f..565bd22 100644
--- a/src/kudu/tserver/tablet_service.cc
+++ b/src/kudu/tserver/tablet_service.cc
@@ -556,7 +556,7 @@ void TabletServiceAdminImpl::AlterSchema(const AlterSchemaRequestPB* req,
tx_state->set_completion_callback(gscoped_ptr<TransactionCompletionCallback>(
new RpcTransactionCompletionCallback<AlterSchemaResponsePB>(context,
- resp)).Pass());
+ resp)));
// Submit the alter schema op. The RPC will be responded to asynchronously.
Status s = tablet_peer->SubmitAlterSchema(std::move(tx_state));
@@ -728,7 +728,7 @@ void TabletServiceImpl::Write(const WriteRequestPB* req,
tx_state->set_completion_callback(gscoped_ptr<TransactionCompletionCallback>(
new RpcTransactionCompletionCallback<WriteResponsePB>(context,
- resp)).Pass());
+ resp)));
// Submit the write. The RPC will be responded to asynchronously.
s = tablet_peer->SubmitWrite(tx_state);
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/c9a20d01/src/kudu/util/debug/trace_event_impl.cc
----------------------------------------------------------------------
diff --git a/src/kudu/util/debug/trace_event_impl.cc b/src/kudu/util/debug/trace_event_impl.cc
index 816dfdb..122cad1 100644
--- a/src/kudu/util/debug/trace_event_impl.cc
+++ b/src/kudu/util/debug/trace_event_impl.cc
@@ -1663,7 +1663,7 @@ void TraceLog::FlushButLeaveBufferIntact(
logged_events_->ReturnChunk(thread_shared_chunk_index_,
std::move(thread_shared_chunk_));
}
- previous_logged_events = logged_events_->CloneForIteration().Pass();
+ previous_logged_events = logged_events_->CloneForIteration();
}
ConvertTraceEventsToTraceFormat(std::move(previous_logged_events),