You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/21 08:16:00 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #5571: drivers: exclude BSD components from build
jerpelea opened a new pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571
## Summary
By default exclude from build all drivers that have BDS license.
Those drivers will be added after user selects ALLOW_BSD_COMPONENTS in the main configuration page
## Impact
LICENSE
## Testing
NONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046828441
@jerpelea the USB_Host as @xiaoxiang781216 said is already Apache license, if you look only hid_parser.c has external copyright, but the code is not used in anywhere, it is there only to make developers life easy case then want to parse HID devices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1047527613
@acassis I am still evaluating it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811076223
##########
File path: drivers/usbhost/Kconfig
##########
@@ -10,6 +10,7 @@ config USBHOST_HAVE_ASYNCH
menuconfig USBHOST
bool "USB Host Driver Support"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
https://github.com/jerpelea/incubator-nuttx/blob/master/drivers/usbhost/Make.defs#L21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046817531
@acassis we still have the dac.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811060202
##########
File path: drivers/analog/Kconfig
##########
@@ -17,6 +17,7 @@ if ANALOG
config ADC
bool "Analog-to-Digital Conversion"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
@acassis during the last months I contacted developer and waited for them to answer. For the files that we can clear the license I would gladly move them to Apache instead of adding BSD barrier. I am open to suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811079972
##########
File path: drivers/usbhost/Kconfig
##########
@@ -10,6 +10,7 @@ config USBHOST_HAVE_ASYNCH
menuconfig USBHOST
bool "USB Host Driver Support"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
> https://github.com/jerpelea/incubator-nuttx/blob/master/drivers/usbhost/Make.defs#L21
>
> I can add a new option for the HID Parser and then ifdef it Does this work for you ?
hid_parser.c is only used by usbhost_hidkbd.c and usbhost_hidmouse.c, it's better to move the dependence to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1049577775
> A possibility to consider: Enable ALLOW_BSD_COMPONENTS by default? Since BSD license is not "viral" this will allow developers to disable it if they have a good reason to do so.
>
> (GPL should remain DISABLED by default as most commercial users cannot deploy that in an embedded product.)
since there aren't that many BSD components left (most of them wait contributors to fill SGA/ICLA) I dont think that we should aim for anything else than pure Apache license by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1049407797
> @yamt the BSD flag in our case is marking all variants of BSD licenses to provide an simplified option
ok. thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811051741
##########
File path: drivers/modem/Kconfig
##########
@@ -14,6 +14,7 @@ if MODEM
config MODEM_U_BLOX
bool "Enable u-blox modem driver"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
It will break your "own" Sony Spresense "lte" config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811076223
##########
File path: drivers/usbhost/Kconfig
##########
@@ -10,6 +10,7 @@ config USBHOST_HAVE_ASYNCH
menuconfig USBHOST
bool "USB Host Driver Support"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
https://github.com/jerpelea/incubator-nuttx/blob/master/drivers/usbhost/Make.defs#L21
I can add a new option for the HID Parser and then ifdef it
Does this work for you ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046829147
@acassis @xiaoxiang781216 both adc and usbhost have been updated with your comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046808933
> @acassis the code is already listed in the LICENSE file
If it is already listed there, there is no need to hide it, BSD license is not like GPL license that enforce itself over other licenses. I think have ADC or USB Host could be compiled in the file binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046803941
@acassis the code is already listed in the LICENSE file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1047375327
i have a question.
where can i find a precise definition of ALLOW_BSD_COMPONENTS?
so-called "BSD license" has a lot of variations. https://en.wikipedia.org/wiki/BSD_licenses
i want to know which ones are covered by this option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1053909920
>By default exclude from build all drivers that have BDS license.
@jerpelea
I think the CI can not detect build errors for BSD licensed drivers if they are excluded from defconfigs.
What do you think about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046829147
@acassis @xiaoxiang781216 both adc and usbhost have been updated according to your comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811074402
##########
File path: drivers/usbhost/Kconfig
##########
@@ -10,6 +10,7 @@ config USBHOST_HAVE_ASYNCH
menuconfig USBHOST
bool "USB Host Driver Support"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
> if the others consider the same please close the PR. I think that if we want to have a clear license everything should be properly defined but I will do what the majority asks to be able to finish the license work.
I think it's fine to let a particular driver depend on BSD, but for the framework code, we need be more careful. adc/usbhost look like already Apache copyright?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046815392
> @acassis please change the licenses on adc/dac if you consider that there is a mistake.
Ok, I will do it since "git blame" confirmed that "Li Zhuoyi" has not contributed a single line of that file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811060202
##########
File path: drivers/analog/Kconfig
##########
@@ -17,6 +17,7 @@ if ANALOG
config ADC
bool "Analog-to-Digital Conversion"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
@acassis during the last months I contacted developer and waited for them to answer. For the files that we can clear the license I would gladly move them to Apache instead of adding BSD barrier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046807226
@acassis you can submit the PR that converts the ADC license to Apache and I can drop the ADC patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r812961698
##########
File path: boards/arm/lpc17xx_40xx/u-blox-c027/configs/nsh/defconfig
##########
@@ -51,8 +50,6 @@ CONFIG_LPC17_40_UART2=y
CONFIG_LPC17_40_UART3=y
CONFIG_MM_REGIONS=2
CONFIG_MODEM=y
-CONFIG_MODEM_U_BLOX=y
Review comment:
this is the nsh config so modem config should not really be there. It is also worth mentioning that it is the only defconfig for this board so I would prefer to keep it without the modem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046802615
@jerpelea When some basic feature of NuttX like ADC or USB Host depends on enabling a "hidden" feature (at least to new users) like BSD Components support, then something is wrong. I think in these extreme cases it is better to list the code inside LICENSE file than hiding a basic/essential feature of the system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r810880282
##########
File path: drivers/power/Kconfig
##########
@@ -375,12 +375,13 @@ config BATTERY_CHARGER
bool "Battery Charger support"
default n
-config BQ2425X
+config Q2425X
Review comment:
should we keep the name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r812993658
##########
File path: boards/arm/lpc17xx_40xx/u-blox-c027/configs/nsh/defconfig
##########
@@ -51,8 +50,6 @@ CONFIG_LPC17_40_UART2=y
CONFIG_LPC17_40_UART3=y
CONFIG_MM_REGIONS=2
CONFIG_MODEM=y
-CONFIG_MODEM_U_BLOX=y
Review comment:
Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r812957517
##########
File path: boards/arm/lpc17xx_40xx/u-blox-c027/configs/nsh/defconfig
##########
@@ -51,8 +50,6 @@ CONFIG_LPC17_40_UART2=y
CONFIG_LPC17_40_UART3=y
CONFIG_MM_REGIONS=2
CONFIG_MODEM=y
-CONFIG_MODEM_U_BLOX=y
Review comment:
if so, let's remove this config instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046812407
@acassis please change the licenses on adc/dac if you consider that there is a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1047186779
@jerpelea I think you also need to update some defconfigs, otherwise the CI will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811077141
##########
File path: drivers/usbhost/Kconfig
##########
@@ -10,6 +10,7 @@ config USBHOST_HAVE_ASYNCH
menuconfig USBHOST
bool "USB Host Driver Support"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
Done: https://github.com/apache/incubator-nuttx/pull/5578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1048530603
@acassis the files from Giorgio Gross have been migrated to Apache license and removed from this patch https://github.com/apache/incubator-nuttx/pull/5592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r813831975
##########
File path: boards/arm/lc823450/lc823450-xgevk/configs/bt/defconfig
##########
@@ -93,8 +93,6 @@ CONFIG_NET_ROUTE=y
CONFIG_NET_STATISTICS=y
CONFIG_NET_TCP=y
CONFIG_NET_TCP_KEEPALIVE=y
-CONFIG_NET_TUN=y
-CONFIG_NET_TUN_PKTSIZE=1500
Review comment:
By default we should not enable other licenses to the default configs except the sim defconfigs.
Each developer can enable the BSD components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r812954166
##########
File path: boards/arm/lpc17xx_40xx/u-blox-c027/configs/nsh/defconfig
##########
@@ -51,8 +50,6 @@ CONFIG_LPC17_40_UART2=y
CONFIG_LPC17_40_UART3=y
CONFIG_MM_REGIONS=2
CONFIG_MODEM=y
-CONFIG_MODEM_U_BLOX=y
Review comment:
I think that we should have Apache only configs for all boards (except sim) to avoid the case when a developer accidentally uses mixed licenses. This way each developer will enable the extra licenses locally and benefit from the extra code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811057405
##########
File path: drivers/modem/Kconfig
##########
@@ -14,6 +14,7 @@ if MODEM
config MODEM_U_BLOX
bool "Enable u-blox modem driver"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
@acassis we have to make a basic build that is APACHE only then each developer can consider if they want to use BSD licenses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r813851214
##########
File path: boards/arm/lc823450/lc823450-xgevk/configs/bt/defconfig
##########
@@ -93,8 +93,6 @@ CONFIG_NET_ROUTE=y
CONFIG_NET_STATISTICS=y
CONFIG_NET_TCP=y
CONFIG_NET_TCP_KEEPALIVE=y
-CONFIG_NET_TUN=y
-CONFIG_NET_TUN_PKTSIZE=1500
Review comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r813828132
##########
File path: boards/arm/lc823450/lc823450-xgevk/configs/bt/defconfig
##########
@@ -93,8 +93,6 @@ CONFIG_NET_ROUTE=y
CONFIG_NET_STATISTICS=y
CONFIG_NET_TCP=y
CONFIG_NET_TCP_KEEPALIVE=y
-CONFIG_NET_TUN=y
-CONFIG_NET_TUN_PKTSIZE=1500
Review comment:
@jerpelea
Could you revert this change and add `CONFIG_ALLOW_BSD_COMPONENTS=y` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1048690126
@yamt the BSD flag in our case is marking all variants of BSD licenses to provide an simplified option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r812961698
##########
File path: boards/arm/lpc17xx_40xx/u-blox-c027/configs/nsh/defconfig
##########
@@ -51,8 +50,6 @@ CONFIG_LPC17_40_UART2=y
CONFIG_LPC17_40_UART3=y
CONFIG_MM_REGIONS=2
CONFIG_MODEM=y
-CONFIG_MODEM_U_BLOX=y
Review comment:
this is the nsh config so modem config should not really be there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1054001505
@masayuki2009 We enable by default the BSD license in the SIM defconfigs to detect this kind of errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811072761
##########
File path: drivers/usbhost/Kconfig
##########
@@ -10,6 +10,7 @@ config USBHOST_HAVE_ASYNCH
menuconfig USBHOST
bool "USB Host Driver Support"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
look like usbhost framework already Apache copyright. Should we put ALLOW_BSD_COMPONENTS to the individual driver instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046807226
@acassis you can submit the PR that converts the ADC license to Apache and I can drop this patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046830437
@xiaoxiang781216 please do a git grep hid_getitem or other functions inside hid_parser.c, I think it is not used in fact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811049464
##########
File path: drivers/analog/Kconfig
##########
@@ -17,6 +17,7 @@ if ANALOG
config ADC
bool "Analog-to-Digital Conversion"
default n
+ depends on ALLOW_BSD_COMPONENTS
Review comment:
@jerpelea I think those file with Copyright from other people that we didn't contact need to be reviewed. In the case of adc.c for example if you run "git blame" you see that "Li Zhuoyi" contributions to the file were removed, but his copyright still there. It is an error and need to be fixed. Just putting it as BSD component will make the already complex config even more complex. How on earth people will image that to use ADC on NuttX he needs to enable BSD license?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046846425
> @xiaoxiang781216 please do a git grep hid_getitem or other functions inside hid_parser.c, I think it is not used in fact.
Yes, nobody really call the function implemented inside hid_parse.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046808933
> @acassis the code is already listed in the LICENSE file
If it is already listed there, there is no need to hide it, BSD license is not like GPL license that enforce itself over other licenses. I think the ADC or USB Host could be compiled in the file binary without issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1046811756
if the others consider the same please close the PR.
I think that if we want to have a clear license everything should be properly defined but I will do what the majority asks to be able to finish the license work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1049240993
A possibility to consider: Enable ALLOW_BSD_COMPONENTS by default? Since BSD license is not "viral" this will allow developers to disable it if they have a good reason to do so.
(GPL should remain DISABLED by default as most commercial users cannot deploy that in an embedded product.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5571: drivers: exclude BSD components from build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r812950809
##########
File path: boards/arm/lpc17xx_40xx/u-blox-c027/configs/nsh/defconfig
##########
@@ -51,8 +50,6 @@ CONFIG_LPC17_40_UART2=y
CONFIG_LPC17_40_UART3=y
CONFIG_MM_REGIONS=2
CONFIG_MODEM=y
-CONFIG_MODEM_U_BLOX=y
Review comment:
should we enable BSD? since it isn't needed anymore without ublox related code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org