You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/06/04 04:55:25 UTC
[GitHub] [cassandra] bereng opened a new pull request #1038: Split ViewComplexTest to avoid timeouts after being moved away from '…
bereng opened a new pull request #1038:
URL: https://github.com/apache/cassandra/pull/1038
…long' junits
patch by Berenguer Blas; reviewed by Ekaterina Dimitrova for CASSANDRA-16611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1038: Split ViewComplexTest to avoid timeouts after being moved away from '…
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1038:
URL: https://github.com/apache/cassandra/pull/1038#issuecomment-855693000
Ci [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/329/workflows/1e501da4-1305-4538-980b-f2b9cff2bf71)
CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/328/workflows/a4c92d3c-597e-4168-96cf-f9e10b54ac7c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1038: Split ViewComplexTest to avoid timeouts after being moved away from '…
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1038:
URL: https://github.com/apache/cassandra/pull/1038#issuecomment-854375971
CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/327/workflows/1666da2b-c5d2-4316-ad88-b6061254309b)
CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/327/workflows/53dc6a34-9d8c-4392-bde6-51434e3f53de)
Unrelated failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1038: Split ViewComplexTest to avoid timeouts after being moved away from '…
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1038:
URL: https://github.com/apache/cassandra/pull/1038#issuecomment-854375971
CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/327/workflows/1666da2b-c5d2-4316-ad88-b6061254309b)
CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/327/workflows/53dc6a34-9d8c-4392-bde6-51434e3f53de)
Unrelated failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng closed pull request #1038: Split ViewComplexTest to avoid timeouts after being moved away from '…
Posted by GitBox <gi...@apache.org>.
bereng closed pull request #1038:
URL: https://github.com/apache/cassandra/pull/1038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1038: Split ViewComplexTest to avoid timeouts after being moved away from '…
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1038:
URL: https://github.com/apache/cassandra/pull/1038#issuecomment-857427375
Squashed & rebased:
CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/336/workflows/60657405-8afb-4500-800f-75a04cba10b2)
CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/336/workflows/1309175d-c63c-418a-90f6-f10cbf03629c)
Unrelated failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 commented on a change in pull request #1038: Split ViewComplexTest to avoid timeouts after being moved away from '…
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on a change in pull request #1038:
URL: https://github.com/apache/cassandra/pull/1038#discussion_r645652944
##########
File path: test/unit/org/apache/cassandra/cql3/ViewComplexLivenessTest.java
##########
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.cql3;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import org.apache.cassandra.db.ColumnFamilyStore;
+import org.apache.cassandra.db.Keyspace;
+import org.apache.cassandra.transport.ProtocolVersion;
+import org.apache.cassandra.utils.FBUtilities;
+
+import static org.apache.cassandra.cql3.ViewComplexTest.createView;
+import static org.apache.cassandra.cql3.ViewComplexTest.updateView;
+import static org.apache.cassandra.cql3.ViewComplexTest.updateViewWithFlush;
+import static org.junit.Assert.assertEquals;
+
+/* This class been split into multiple ones bc of timeout issues CASSANDRA-16670
Review comment:
This is a super nit but I just realized we say we split a test into tests that include also this one...reads weird :-)
We can copy-paste this everywhere
##########
File path: test/unit/org/apache/cassandra/cql3/ViewComplexLivenessTest.java
##########
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.cql3;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import org.apache.cassandra.db.ColumnFamilyStore;
+import org.apache.cassandra.db.Keyspace;
+import org.apache.cassandra.transport.ProtocolVersion;
+import org.apache.cassandra.utils.FBUtilities;
+
+import static org.apache.cassandra.cql3.ViewComplexTest.createView;
+import static org.apache.cassandra.cql3.ViewComplexTest.updateView;
+import static org.apache.cassandra.cql3.ViewComplexTest.updateViewWithFlush;
+import static org.junit.Assert.assertEquals;
+
+/* This class been split into multiple ones bc of timeout issues CASSANDRA-16670
Review comment:
```suggestion
/* ViewComplexTest class has been split into multiple ones because of timeout issues (CASSANDRA-16670)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org