[GitHub] [airflow] brighton1101 commented on a change in pull request #12467: Added support for DSS, ECDSA, and Ed25519 private keys in SSHHook

[GitBox <gi...@apache.org>]

brighton1101 commented on a change in pull request #12467:
URL: https://github.com/apache/airflow/pull/12467#discussion_r535841354



##########
File path: airflow/config_templates/config.yml
##########
@@ -2053,3 +2053,13 @@
       type: string
       example: ~
       default: "NamedHivePartitionSensor"
+- name: ssh
+  description: ~
+  options:
+    - name: private_keys_algorithm_support
+      description: |
+        Comma separated list of ssh algorithms names (following `ssh-keygen` naming) supported by
+        SSH hook
+      type: string
+      example: ~
+      default: "dsa,ecdsa,ed25519,rsa"

Review comment:
       I don't think I have a strong enough argument for either option on this. Does Airflow configuration typically allow for limitations on user input like this?
   
   Let me know what you guys decide and I'll change it in either direction (by either removing the config altogether, or adding reconciliation logic that will remove algos not specified in the config)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org