You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/10 02:43:34 UTC

[GitHub] [incubator-mxnet] DickJC123 opened a new pull request #19328: [BUGFIX] [1.8.x] Backport of "Avoid logging seed for skipped tests #19322"

DickJC123 opened a new pull request #19328:
URL: https://github.com/apache/incubator-mxnet/pull/19328


   ## Description ##
   This fixes issue https://github.com/apache/incubator-mxnet/issues/19255, where it was noted that when a unittest was skipped, the skip-exception caused the with_seed() decorator to log the seed. While the 1.8.x branch uses nosetests, not pytest, the same behavior is seen on 1.8..x. With this PR the seed is no longer logged.
   
   This PR doesn't have any testing added- I will inspect the CI log for skipped tests such as test_operator.py:test_activation to verify that the seed logging has been successfully eliminated.
   
   This is identical to the master -> 1.x backport PR https://github.com/apache/incubator-mxnet/pull/19327.
   
   @leezu @samskalicky
   
   
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19328: [BUGFIX] [1.8.x] Backport of "Avoid logging seed for skipped tests #19322"

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19328:
URL: https://github.com/apache/incubator-mxnet/pull/19328#issuecomment-706473010


   Hey @DickJC123 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-gpu, windows-gpu, website, miscellaneous, centos-gpu, unix-cpu, sanity, centos-cpu, windows-cpu, edge, clang]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] DickJC123 commented on pull request #19328: [BUGFIX] [1.8.x] Backport of "Avoid logging seed for skipped tests #19322"

Posted by GitBox <gi...@apache.org>.
DickJC123 commented on pull request #19328:
URL: https://github.com/apache/incubator-mxnet/pull/19328#issuecomment-706484328


   I can verify the PR works on 1.8.x, similar to my comments for the identical 1.x PR: https://github.com/apache/incubator-mxnet/pull/19327#issuecomment-706481601


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] DickJC123 closed pull request #19328: [BUGFIX] [1.8.x] Backport of "Avoid logging seed for skipped tests #19322"

Posted by GitBox <gi...@apache.org>.
DickJC123 closed pull request #19328:
URL: https://github.com/apache/incubator-mxnet/pull/19328


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org