[GitHub] [activemq] cshannon commented on pull request #848: Feature/replica broker

[GitBox <gi...@apache.org>]

cshannon commented on PR #848:
URL: https://github.com/apache/activemq/pull/848#issuecomment-1377150392

   I haven't gone through much of this yet but the number 1 thing is anything here needs to be isolated and as Matt pointed out I have some concerns with internal changes. This needs to not impact anything in the broker if it's not running so any changes that would impact performance or could introduce other issues/bugs would be a problem. Essentially if it's disabled (which it will be by default) then the broker shouldn't behave any differently than today. 
   
   I also wonder whether or not this should be part of the core broker. At this point I'm not really convinced this should be included and may be better as a stand alone plugin that is maintained separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org