You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2011/03/30 20:10:05 UTC
[jira] [Created] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Intermittent TestRegionRebalancing failure
------------------------------------------
Key: HBASE-3716
URL: https://issues.apache.org/jira/browse/HBASE-3716
Project: HBase
Issue Type: Bug
Components: master
Reporter: Ted Yu
Assignee: Ted Yu
See HBase-TRUNK build #1820
This could be due to HBASE-3681
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3716:
--------------------------
Attachment: 3716-addendum.txt
Removed an unnecessary assertion.
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716-addendum.txt, 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013582#comment-13013582 ]
Ted Yu commented on HBASE-3716:
-------------------------------
TestLoadBalancer passes too.
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014402#comment-13014402 ]
stack commented on HBASE-3716:
------------------------------
I applied the addendum. Thanks Ted.
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716-addendum.txt, 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014913#comment-13014913 ]
Hudson commented on HBASE-3716:
-------------------------------
Integrated in HBase-TRUNK #1824 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1824/])
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716-addendum.txt, 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014092#comment-13014092 ]
Jean-Daniel Cryans commented on HBASE-3716:
-------------------------------------------
Good point, I didn't look carefully enough... mmm ok let's just keep the boolean, but please rename to something that better represents it's meaning like _balancerRan_.
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014082#comment-13014082 ]
Ted Yu commented on HBASE-3716:
-------------------------------
w.r.t. the second comment, I am not sure that we should bypass calling this.cpHost.postBalance()
I think the boolean return value should be passed to postBalance() as well. But that requires more changes.
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014071#comment-13014071 ]
Jean-Daniel Cryans commented on HBASE-3716:
-------------------------------------------
This sort of operation can be done better:
bq. ret = plans != null ? true : false;
All you gotta do is to take the return value of the condition and that's it.
But even then you don't need to add an additional boolean since the next line is:
bq. if (plans != null && !plans.isEmpty()) {
Won't adding a _else_ statement in order to _return false_ be more readable?
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3716:
--------------------------
Attachment: 3716.txt
Revised again according to review.
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-3716.
--------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Committed to TRUNK. Thanks for the patch Ted.
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013569#comment-13013569 ]
Jean-Daniel Cryans commented on HBASE-3716:
-------------------------------------------
Yeah the test should check against the same slop that's configured.
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3716:
--------------------------
Attachment: (was: 3716.txt)
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-3716) Intermittent
TestRegionRebalancing failure
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HBASE-3716 started by Ted Yu.
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-3716:
----------------------------------
Fix Version/s: 0.92.0
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3716-addendum.txt, 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3716:
--------------------------
Attachment: (was: 3716.txt)
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3716:
--------------------------
Attachment: 3716.txt
Also made changes to the return value of HMaster.balance().
Previously true was always returned even if there was no actual balancing action.
TestRegionRebalancing, TestMultiParallel and TestMasterObserver all pass.
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3716:
--------------------------
Attachment: 3716.txt
Changed assignment of ret according to J-D's review
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3716) Intermittent TestRegionRebalancing
failure
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3716:
--------------------------
Description:
See HBase-TRUNK build #1820
This could be due to HBASE-3681
In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
However, assertRegionsAreBalanced() uses 10% slop.
One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
was:
See HBase-TRUNK build #1820
This could be due to HBASE-3681
> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
> Key: HBASE-3716
> URL: https://issues.apache.org/jira/browse/HBASE-3716
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Ted Yu
> Assignee: Ted Yu
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop" value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira