You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Christopher <ct...@apache.org> on 2013/11/19 15:05:41 UTC

Re: remove wikisearch from 1.4.x development?

It seems like consensus was not really reached on the issue. I don't
have a very strong opinion on this, but it does seem that changing the
packaging for 1.4.x for a bugfix release in a major way like this is
not really a nice thing to do to users.

There's a risk users will have based code agaisnt 1.4.x on this
example, and it wouldn't be good to break it. At the very least,
keeping the example in there (and not modifying the way it uses the
public API), acts as a test, to ensure that we don't make any changes
that makes 1.4.x user code incompatible with the latest 1.4.x
development, when they've based their code on what we've suggested
through our examples.

Since a version of wikisearch has been released with 1.4.4, and we
already have a separate git repo for wikisearch development, I would
be okay dropping it from the main repo's 1.4.5-SNAPSHOT branch, if we
were willing to continue releasing wikisearch from its own repo to
keep it working with the latest 1.4.x whenever we release accumulo
1.4.x.

In other words, it doesn't have to exist in the 1.4.x branch, but it
should still follow the 1.4.x releases, being released from the
contrib repo, keeping in line with the packaging precedent for the 1.4
series.


--
Christopher L Tubbs II
http://gravatar.com/ctubbsii


On Tue, Oct 22, 2013 at 1:24 PM, Keith Turner <ke...@deenlo.com> wrote:
> On Tue, Oct 22, 2013 at 1:03 PM, Sean Busbey <bu...@cloudera.com> wrote:
>
>> On Tue, Oct 22, 2013 at 10:15 AM, Keith Turner <ke...@deenlo.com> wrote:
>>
>> >
>> > I also would not oppose removing it.   At the time the decision was made,
>> > there was no cost to leaving it in 1.4.  If it is removed, will whats
>> > currently in contrib work against 1.4+Hadoop 1.0?
>> >
>> >
>>  Accumulo 1.4.4 (or current SNAPSHOT?) with Hadoop 1.0 (or Hadoop
>> 0.20.203.0)?
>>
>
> 0.20.203.0 is whats in the 1.4 pom, so that I guess.   I suppose it would
> make more sense to try snapshot, since that where it would be removed.   If
> it is removed and whats in contrib does work, then we could place a pointer
> to contrib in 1.4.5-SNAPSHOT.
>
>
>>
>> Just want to make sure I arrange to have the correct thing tested.
>>
>> --
>> Sean
>>

Re: remove wikisearch from 1.4.x development?

Posted by Sean Busbey <bu...@clouderagovt.com>.
On Thu, Nov 21, 2013 at 3:17 PM, Christopher <ct...@apache.org> wrote:

> I favor #2 (because it hasn't actually been removed from 1.4.x, so
> there isn't any "putting back" necessary), but #1 is fine with me,
> too, as long as we release a version of this example that will work
> against 1.4.5 Accumulo.
>
>

Even when #2 is phrased properly as "leave it in Accumulo 1.4.x", I'd still
favor #1 just because it keeps work on wikisearch in one place (the contrib
repo) which makes more sense to me, esp. given the original discussions on
ACCUMULO-600.


-- 
Sean

Re: remove wikisearch from 1.4.x development?

Posted by Christopher <ct...@apache.org>.
I favor #2 (because it hasn't actually been removed from 1.4.x, so
there isn't any "putting back" necessary), but #1 is fine with me,
too, as long as we release a version of this example that will work
against 1.4.5 Accumulo.

--
Christopher L Tubbs II
http://gravatar.com/ctubbsii


On Thu, Nov 21, 2013 at 4:12 PM, Bill Havanki <bh...@clouderagovt.com> wrote:
> I'll just wade in here… :/
>
> The contrib wikisearch relies on MapFileIterator, which was introduced in
> Accumulo 1.5.0. It used to use MyMapFile, which was purged way back in
> ACCUMULO-288, early 2012. (This predates the split of wikisearch into a
> contrib.)
>
> So, the contrib wikisearch won't even compile against 1.4.x, and a trail of
> commits have been made since the split. We have options, then:
>
> 1. Create a branch in the contrib and get it working for 1.4.x.
> 2. Put the 1.4.x non-contrib copy back, and "do stuff" (Sean's
> techno-jargon) to get it to work for Hadoop 2. Leave the contrib for 1.5.0+.
> 3. Backport MapFileIterator (et al.?) to 1.4.x so the contrib works as is
> (hopefully).
> 4. Other?
>
> I lean toward #1.
>
> Bill
>
>
> On Thu, Nov 21, 2013 at 3:42 PM, Christopher <ct...@apache.org> wrote:
>
>> Are you suggesting skipping a version number, if necessary, or that we
>> can wait to push out a 1.4.6 WS until 1.4.6 ACC?
>>
>> If the latter, I'm not sure we can assume there will be a 1.4.6 ACC.
>> To both options, it seems that 1.4.4 WS won't work on 1.4.5 ACC
>> without changes to support Hadoop 2, so it seems that some newer
>> release of WS is warranted.
>>
>> --
>> Christopher L Tubbs II
>> http://gravatar.com/ctubbsii
>>
>>
>> On Tue, Nov 19, 2013 at 11:15 PM, Michael Berman <mb...@sqrrl.com>
>> wrote:
>> >>
>> >> Imagine 1.4.4 WS is compatible with 1.4.5 ACC, but then 1.4.6 introduces
>> >> a change that causes us to bump WS... now 1.4.5 WS is needed for 1.4.6
>> >> ACC, but won't work on 1.4.5 ACC
>> >
>> >
>> > Small point...in this situation, I don't see any reason 1.4.5 WS needs to
>> > exist at all.  1.4.6 WS could be the minimum version for 1.4.6 ACC.
>> >
>> >
>> > On Tue, Nov 19, 2013 at 5:19 PM, Christopher <ct...@apache.org>
>> wrote:
>> >
>> >> On Tue, Nov 19, 2013 at 9:59 AM, Sean Busbey <
>> busbey+ml@clouderagovt.com>
>> >> wrote:
>> >> > On Tue, Nov 19, 2013 at 8:05 AM, Christopher <ct...@apache.org>
>> >> wrote:
>> >> [snip]
>> >> > We would expressly not being claiming that wikisearch is a part of our
>> >> > public API, correct?
>> >>
>> >> I don't understand this question.
>> >>
>> >> > What kind of testing would be involved for doing a release of the
>> >> > wikisearch contrib? Just unit tests as is done with it as part of the
>> >> 1.4.x
>> >> > branch?
>> >>
>> >> Usually, when we do a release, we test that all the examples work
>> >> according to the relevant README, not just verify unit tests pass in
>> >> the build.
>> >>
>> >> > Would the releases from the contrib repo need to have version numbers
>> >> that
>> >> > match the 1.4.x line, or would a compatibility statement for each
>> release
>> >> > be sufficient?
>> >>
>> >> Well, Wikisearch has already been released as 1.4.0, 1.4.1, 1.4.2,
>> >> 1.4.3, and 1.4.4. Now that it's a sub-project, we don't need to
>> >> continue versioning together if it will work with multiple versions,
>> >> but it could be confusing if it didn't. Imagine 1.4.4 WS is compatible
>> >> with 1.4.5 ACC, but then 1.4.6 introduces a change that causes us to
>> >> bump WS... now 1.4.5 WS is needed for 1.4.6 ACC, but won't work on
>> >> 1.4.5 ACC. That's very confusing to users, even with a compatibility
>> >> statement.
>> >>
>> >> Since you indicated that changes to Wikisearch 1.4.4 would be needed
>> >> to make it compatible with Hadoop 2 in Accumulo 1.4.5, it seems to
>> >> make sense to bump it also. Whether we should continue doing this or
>> >> not, is a discussion we can have at another time... I can see merits
>> >> in both options... but I wouldn't want to change the convention on a
>> >> bugfix/minor release even if we do agree to separate the versioning in
>> >> the future.
>> >>
>> >> --
>> >> Christopher L Tubbs II
>> >> http://gravatar.com/ctubbsii
>> >>
>>
>
>
>
> --
> | - - -
> | Bill Havanki
> | Solutions Architect, Cloudera Government Solutions
> | - - -

Re: remove wikisearch from 1.4.x development?

Posted by Christopher <ct...@apache.org>.
Gotcha.

--
Christopher L Tubbs II
http://gravatar.com/ctubbsii


On Thu, Nov 21, 2013 at 4:19 PM, Michael Berman <mb...@sqrrl.com> wrote:
> Sorry, I was talking about the versioning issue in general, not this
> specific release.  If there needs to be WS changes for 1.4.5, then there
> will be a 1.4.5 WS and there's no problem.  I was responding to your
> concern about them getting out of sync if there's an ACC release that
> *doesn't* motivate a WS release, specifically in your scenario I quoted.
>  In that case, we could just skip the intervening WS numbers once it does
> have to change, so even if we don't demand a WS for every ACC release, we
> never need to have a "you need 1.4.5 to work with 1.4.6" situation.
>
>
> On Thu, Nov 21, 2013 at 4:12 PM, Bill Havanki <bh...@clouderagovt.com>wrote:
>
>> I'll just wade in here… :/
>>
>> The contrib wikisearch relies on MapFileIterator, which was introduced in
>> Accumulo 1.5.0. It used to use MyMapFile, which was purged way back in
>> ACCUMULO-288, early 2012. (This predates the split of wikisearch into a
>> contrib.)
>>
>> So, the contrib wikisearch won't even compile against 1.4.x, and a trail of
>> commits have been made since the split. We have options, then:
>>
>> 1. Create a branch in the contrib and get it working for 1.4.x.
>> 2. Put the 1.4.x non-contrib copy back, and "do stuff" (Sean's
>> techno-jargon) to get it to work for Hadoop 2. Leave the contrib for
>> 1.5.0+.
>> 3. Backport MapFileIterator (et al.?) to 1.4.x so the contrib works as is
>> (hopefully).
>> 4. Other?
>>
>> I lean toward #1.
>>
>> Bill
>>
>>
>> On Thu, Nov 21, 2013 at 3:42 PM, Christopher <ct...@apache.org> wrote:
>>
>> > Are you suggesting skipping a version number, if necessary, or that we
>> > can wait to push out a 1.4.6 WS until 1.4.6 ACC?
>> >
>> > If the latter, I'm not sure we can assume there will be a 1.4.6 ACC.
>> > To both options, it seems that 1.4.4 WS won't work on 1.4.5 ACC
>> > without changes to support Hadoop 2, so it seems that some newer
>> > release of WS is warranted.
>> >
>> > --
>> > Christopher L Tubbs II
>> > http://gravatar.com/ctubbsii
>> >
>> >
>> > On Tue, Nov 19, 2013 at 11:15 PM, Michael Berman <mb...@sqrrl.com>
>> > wrote:
>> > >>
>> > >> Imagine 1.4.4 WS is compatible with 1.4.5 ACC, but then 1.4.6
>> introduces
>> > >> a change that causes us to bump WS... now 1.4.5 WS is needed for 1.4.6
>> > >> ACC, but won't work on 1.4.5 ACC
>> > >
>> > >
>> > > Small point...in this situation, I don't see any reason 1.4.5 WS needs
>> to
>> > > exist at all.  1.4.6 WS could be the minimum version for 1.4.6 ACC.
>> > >
>> > >
>> > > On Tue, Nov 19, 2013 at 5:19 PM, Christopher <ct...@apache.org>
>> > wrote:
>> > >
>> > >> On Tue, Nov 19, 2013 at 9:59 AM, Sean Busbey <
>> > busbey+ml@clouderagovt.com>
>> > >> wrote:
>> > >> > On Tue, Nov 19, 2013 at 8:05 AM, Christopher <ct...@apache.org>
>> > >> wrote:
>> > >> [snip]
>> > >> > We would expressly not being claiming that wikisearch is a part of
>> our
>> > >> > public API, correct?
>> > >>
>> > >> I don't understand this question.
>> > >>
>> > >> > What kind of testing would be involved for doing a release of the
>> > >> > wikisearch contrib? Just unit tests as is done with it as part of
>> the
>> > >> 1.4.x
>> > >> > branch?
>> > >>
>> > >> Usually, when we do a release, we test that all the examples work
>> > >> according to the relevant README, not just verify unit tests pass in
>> > >> the build.
>> > >>
>> > >> > Would the releases from the contrib repo need to have version
>> numbers
>> > >> that
>> > >> > match the 1.4.x line, or would a compatibility statement for each
>> > release
>> > >> > be sufficient?
>> > >>
>> > >> Well, Wikisearch has already been released as 1.4.0, 1.4.1, 1.4.2,
>> > >> 1.4.3, and 1.4.4. Now that it's a sub-project, we don't need to
>> > >> continue versioning together if it will work with multiple versions,
>> > >> but it could be confusing if it didn't. Imagine 1.4.4 WS is compatible
>> > >> with 1.4.5 ACC, but then 1.4.6 introduces a change that causes us to
>> > >> bump WS... now 1.4.5 WS is needed for 1.4.6 ACC, but won't work on
>> > >> 1.4.5 ACC. That's very confusing to users, even with a compatibility
>> > >> statement.
>> > >>
>> > >> Since you indicated that changes to Wikisearch 1.4.4 would be needed
>> > >> to make it compatible with Hadoop 2 in Accumulo 1.4.5, it seems to
>> > >> make sense to bump it also. Whether we should continue doing this or
>> > >> not, is a discussion we can have at another time... I can see merits
>> > >> in both options... but I wouldn't want to change the convention on a
>> > >> bugfix/minor release even if we do agree to separate the versioning in
>> > >> the future.
>> > >>
>> > >> --
>> > >> Christopher L Tubbs II
>> > >> http://gravatar.com/ctubbsii
>> > >>
>> >
>>
>>
>>
>> --
>> | - - -
>> | Bill Havanki
>> | Solutions Architect, Cloudera Government Solutions
>> | - - -
>>

Re: remove wikisearch from 1.4.x development?

Posted by Michael Berman <mb...@sqrrl.com>.
Sorry, I was talking about the versioning issue in general, not this
specific release.  If there needs to be WS changes for 1.4.5, then there
will be a 1.4.5 WS and there's no problem.  I was responding to your
concern about them getting out of sync if there's an ACC release that
*doesn't* motivate a WS release, specifically in your scenario I quoted.
 In that case, we could just skip the intervening WS numbers once it does
have to change, so even if we don't demand a WS for every ACC release, we
never need to have a "you need 1.4.5 to work with 1.4.6" situation.


On Thu, Nov 21, 2013 at 4:12 PM, Bill Havanki <bh...@clouderagovt.com>wrote:

> I'll just wade in here… :/
>
> The contrib wikisearch relies on MapFileIterator, which was introduced in
> Accumulo 1.5.0. It used to use MyMapFile, which was purged way back in
> ACCUMULO-288, early 2012. (This predates the split of wikisearch into a
> contrib.)
>
> So, the contrib wikisearch won't even compile against 1.4.x, and a trail of
> commits have been made since the split. We have options, then:
>
> 1. Create a branch in the contrib and get it working for 1.4.x.
> 2. Put the 1.4.x non-contrib copy back, and "do stuff" (Sean's
> techno-jargon) to get it to work for Hadoop 2. Leave the contrib for
> 1.5.0+.
> 3. Backport MapFileIterator (et al.?) to 1.4.x so the contrib works as is
> (hopefully).
> 4. Other?
>
> I lean toward #1.
>
> Bill
>
>
> On Thu, Nov 21, 2013 at 3:42 PM, Christopher <ct...@apache.org> wrote:
>
> > Are you suggesting skipping a version number, if necessary, or that we
> > can wait to push out a 1.4.6 WS until 1.4.6 ACC?
> >
> > If the latter, I'm not sure we can assume there will be a 1.4.6 ACC.
> > To both options, it seems that 1.4.4 WS won't work on 1.4.5 ACC
> > without changes to support Hadoop 2, so it seems that some newer
> > release of WS is warranted.
> >
> > --
> > Christopher L Tubbs II
> > http://gravatar.com/ctubbsii
> >
> >
> > On Tue, Nov 19, 2013 at 11:15 PM, Michael Berman <mb...@sqrrl.com>
> > wrote:
> > >>
> > >> Imagine 1.4.4 WS is compatible with 1.4.5 ACC, but then 1.4.6
> introduces
> > >> a change that causes us to bump WS... now 1.4.5 WS is needed for 1.4.6
> > >> ACC, but won't work on 1.4.5 ACC
> > >
> > >
> > > Small point...in this situation, I don't see any reason 1.4.5 WS needs
> to
> > > exist at all.  1.4.6 WS could be the minimum version for 1.4.6 ACC.
> > >
> > >
> > > On Tue, Nov 19, 2013 at 5:19 PM, Christopher <ct...@apache.org>
> > wrote:
> > >
> > >> On Tue, Nov 19, 2013 at 9:59 AM, Sean Busbey <
> > busbey+ml@clouderagovt.com>
> > >> wrote:
> > >> > On Tue, Nov 19, 2013 at 8:05 AM, Christopher <ct...@apache.org>
> > >> wrote:
> > >> [snip]
> > >> > We would expressly not being claiming that wikisearch is a part of
> our
> > >> > public API, correct?
> > >>
> > >> I don't understand this question.
> > >>
> > >> > What kind of testing would be involved for doing a release of the
> > >> > wikisearch contrib? Just unit tests as is done with it as part of
> the
> > >> 1.4.x
> > >> > branch?
> > >>
> > >> Usually, when we do a release, we test that all the examples work
> > >> according to the relevant README, not just verify unit tests pass in
> > >> the build.
> > >>
> > >> > Would the releases from the contrib repo need to have version
> numbers
> > >> that
> > >> > match the 1.4.x line, or would a compatibility statement for each
> > release
> > >> > be sufficient?
> > >>
> > >> Well, Wikisearch has already been released as 1.4.0, 1.4.1, 1.4.2,
> > >> 1.4.3, and 1.4.4. Now that it's a sub-project, we don't need to
> > >> continue versioning together if it will work with multiple versions,
> > >> but it could be confusing if it didn't. Imagine 1.4.4 WS is compatible
> > >> with 1.4.5 ACC, but then 1.4.6 introduces a change that causes us to
> > >> bump WS... now 1.4.5 WS is needed for 1.4.6 ACC, but won't work on
> > >> 1.4.5 ACC. That's very confusing to users, even with a compatibility
> > >> statement.
> > >>
> > >> Since you indicated that changes to Wikisearch 1.4.4 would be needed
> > >> to make it compatible with Hadoop 2 in Accumulo 1.4.5, it seems to
> > >> make sense to bump it also. Whether we should continue doing this or
> > >> not, is a discussion we can have at another time... I can see merits
> > >> in both options... but I wouldn't want to change the convention on a
> > >> bugfix/minor release even if we do agree to separate the versioning in
> > >> the future.
> > >>
> > >> --
> > >> Christopher L Tubbs II
> > >> http://gravatar.com/ctubbsii
> > >>
> >
>
>
>
> --
> | - - -
> | Bill Havanki
> | Solutions Architect, Cloudera Government Solutions
> | - - -
>

Re: remove wikisearch from 1.4.x development?

Posted by Bill Havanki <bh...@clouderagovt.com>.
I'll just wade in here… :/

The contrib wikisearch relies on MapFileIterator, which was introduced in
Accumulo 1.5.0. It used to use MyMapFile, which was purged way back in
ACCUMULO-288, early 2012. (This predates the split of wikisearch into a
contrib.)

So, the contrib wikisearch won't even compile against 1.4.x, and a trail of
commits have been made since the split. We have options, then:

1. Create a branch in the contrib and get it working for 1.4.x.
2. Put the 1.4.x non-contrib copy back, and "do stuff" (Sean's
techno-jargon) to get it to work for Hadoop 2. Leave the contrib for 1.5.0+.
3. Backport MapFileIterator (et al.?) to 1.4.x so the contrib works as is
(hopefully).
4. Other?

I lean toward #1.

Bill


On Thu, Nov 21, 2013 at 3:42 PM, Christopher <ct...@apache.org> wrote:

> Are you suggesting skipping a version number, if necessary, or that we
> can wait to push out a 1.4.6 WS until 1.4.6 ACC?
>
> If the latter, I'm not sure we can assume there will be a 1.4.6 ACC.
> To both options, it seems that 1.4.4 WS won't work on 1.4.5 ACC
> without changes to support Hadoop 2, so it seems that some newer
> release of WS is warranted.
>
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>
>
> On Tue, Nov 19, 2013 at 11:15 PM, Michael Berman <mb...@sqrrl.com>
> wrote:
> >>
> >> Imagine 1.4.4 WS is compatible with 1.4.5 ACC, but then 1.4.6 introduces
> >> a change that causes us to bump WS... now 1.4.5 WS is needed for 1.4.6
> >> ACC, but won't work on 1.4.5 ACC
> >
> >
> > Small point...in this situation, I don't see any reason 1.4.5 WS needs to
> > exist at all.  1.4.6 WS could be the minimum version for 1.4.6 ACC.
> >
> >
> > On Tue, Nov 19, 2013 at 5:19 PM, Christopher <ct...@apache.org>
> wrote:
> >
> >> On Tue, Nov 19, 2013 at 9:59 AM, Sean Busbey <
> busbey+ml@clouderagovt.com>
> >> wrote:
> >> > On Tue, Nov 19, 2013 at 8:05 AM, Christopher <ct...@apache.org>
> >> wrote:
> >> [snip]
> >> > We would expressly not being claiming that wikisearch is a part of our
> >> > public API, correct?
> >>
> >> I don't understand this question.
> >>
> >> > What kind of testing would be involved for doing a release of the
> >> > wikisearch contrib? Just unit tests as is done with it as part of the
> >> 1.4.x
> >> > branch?
> >>
> >> Usually, when we do a release, we test that all the examples work
> >> according to the relevant README, not just verify unit tests pass in
> >> the build.
> >>
> >> > Would the releases from the contrib repo need to have version numbers
> >> that
> >> > match the 1.4.x line, or would a compatibility statement for each
> release
> >> > be sufficient?
> >>
> >> Well, Wikisearch has already been released as 1.4.0, 1.4.1, 1.4.2,
> >> 1.4.3, and 1.4.4. Now that it's a sub-project, we don't need to
> >> continue versioning together if it will work with multiple versions,
> >> but it could be confusing if it didn't. Imagine 1.4.4 WS is compatible
> >> with 1.4.5 ACC, but then 1.4.6 introduces a change that causes us to
> >> bump WS... now 1.4.5 WS is needed for 1.4.6 ACC, but won't work on
> >> 1.4.5 ACC. That's very confusing to users, even with a compatibility
> >> statement.
> >>
> >> Since you indicated that changes to Wikisearch 1.4.4 would be needed
> >> to make it compatible with Hadoop 2 in Accumulo 1.4.5, it seems to
> >> make sense to bump it also. Whether we should continue doing this or
> >> not, is a discussion we can have at another time... I can see merits
> >> in both options... but I wouldn't want to change the convention on a
> >> bugfix/minor release even if we do agree to separate the versioning in
> >> the future.
> >>
> >> --
> >> Christopher L Tubbs II
> >> http://gravatar.com/ctubbsii
> >>
>



-- 
| - - -
| Bill Havanki
| Solutions Architect, Cloudera Government Solutions
| - - -

Re: remove wikisearch from 1.4.x development?

Posted by Christopher <ct...@apache.org>.
Are you suggesting skipping a version number, if necessary, or that we
can wait to push out a 1.4.6 WS until 1.4.6 ACC?

If the latter, I'm not sure we can assume there will be a 1.4.6 ACC.
To both options, it seems that 1.4.4 WS won't work on 1.4.5 ACC
without changes to support Hadoop 2, so it seems that some newer
release of WS is warranted.

--
Christopher L Tubbs II
http://gravatar.com/ctubbsii


On Tue, Nov 19, 2013 at 11:15 PM, Michael Berman <mb...@sqrrl.com> wrote:
>>
>> Imagine 1.4.4 WS is compatible with 1.4.5 ACC, but then 1.4.6 introduces
>> a change that causes us to bump WS... now 1.4.5 WS is needed for 1.4.6
>> ACC, but won't work on 1.4.5 ACC
>
>
> Small point...in this situation, I don't see any reason 1.4.5 WS needs to
> exist at all.  1.4.6 WS could be the minimum version for 1.4.6 ACC.
>
>
> On Tue, Nov 19, 2013 at 5:19 PM, Christopher <ct...@apache.org> wrote:
>
>> On Tue, Nov 19, 2013 at 9:59 AM, Sean Busbey <bu...@clouderagovt.com>
>> wrote:
>> > On Tue, Nov 19, 2013 at 8:05 AM, Christopher <ct...@apache.org>
>> wrote:
>> [snip]
>> > We would expressly not being claiming that wikisearch is a part of our
>> > public API, correct?
>>
>> I don't understand this question.
>>
>> > What kind of testing would be involved for doing a release of the
>> > wikisearch contrib? Just unit tests as is done with it as part of the
>> 1.4.x
>> > branch?
>>
>> Usually, when we do a release, we test that all the examples work
>> according to the relevant README, not just verify unit tests pass in
>> the build.
>>
>> > Would the releases from the contrib repo need to have version numbers
>> that
>> > match the 1.4.x line, or would a compatibility statement for each release
>> > be sufficient?
>>
>> Well, Wikisearch has already been released as 1.4.0, 1.4.1, 1.4.2,
>> 1.4.3, and 1.4.4. Now that it's a sub-project, we don't need to
>> continue versioning together if it will work with multiple versions,
>> but it could be confusing if it didn't. Imagine 1.4.4 WS is compatible
>> with 1.4.5 ACC, but then 1.4.6 introduces a change that causes us to
>> bump WS... now 1.4.5 WS is needed for 1.4.6 ACC, but won't work on
>> 1.4.5 ACC. That's very confusing to users, even with a compatibility
>> statement.
>>
>> Since you indicated that changes to Wikisearch 1.4.4 would be needed
>> to make it compatible with Hadoop 2 in Accumulo 1.4.5, it seems to
>> make sense to bump it also. Whether we should continue doing this or
>> not, is a discussion we can have at another time... I can see merits
>> in both options... but I wouldn't want to change the convention on a
>> bugfix/minor release even if we do agree to separate the versioning in
>> the future.
>>
>> --
>> Christopher L Tubbs II
>> http://gravatar.com/ctubbsii
>>

Re: remove wikisearch from 1.4.x development?

Posted by Michael Berman <mb...@sqrrl.com>.
>
> Imagine 1.4.4 WS is compatible with 1.4.5 ACC, but then 1.4.6 introduces
> a change that causes us to bump WS... now 1.4.5 WS is needed for 1.4.6
> ACC, but won't work on 1.4.5 ACC


Small point...in this situation, I don't see any reason 1.4.5 WS needs to
exist at all.  1.4.6 WS could be the minimum version for 1.4.6 ACC.


On Tue, Nov 19, 2013 at 5:19 PM, Christopher <ct...@apache.org> wrote:

> On Tue, Nov 19, 2013 at 9:59 AM, Sean Busbey <bu...@clouderagovt.com>
> wrote:
> > On Tue, Nov 19, 2013 at 8:05 AM, Christopher <ct...@apache.org>
> wrote:
> [snip]
> > We would expressly not being claiming that wikisearch is a part of our
> > public API, correct?
>
> I don't understand this question.
>
> > What kind of testing would be involved for doing a release of the
> > wikisearch contrib? Just unit tests as is done with it as part of the
> 1.4.x
> > branch?
>
> Usually, when we do a release, we test that all the examples work
> according to the relevant README, not just verify unit tests pass in
> the build.
>
> > Would the releases from the contrib repo need to have version numbers
> that
> > match the 1.4.x line, or would a compatibility statement for each release
> > be sufficient?
>
> Well, Wikisearch has already been released as 1.4.0, 1.4.1, 1.4.2,
> 1.4.3, and 1.4.4. Now that it's a sub-project, we don't need to
> continue versioning together if it will work with multiple versions,
> but it could be confusing if it didn't. Imagine 1.4.4 WS is compatible
> with 1.4.5 ACC, but then 1.4.6 introduces a change that causes us to
> bump WS... now 1.4.5 WS is needed for 1.4.6 ACC, but won't work on
> 1.4.5 ACC. That's very confusing to users, even with a compatibility
> statement.
>
> Since you indicated that changes to Wikisearch 1.4.4 would be needed
> to make it compatible with Hadoop 2 in Accumulo 1.4.5, it seems to
> make sense to bump it also. Whether we should continue doing this or
> not, is a discussion we can have at another time... I can see merits
> in both options... but I wouldn't want to change the convention on a
> bugfix/minor release even if we do agree to separate the versioning in
> the future.
>
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>

Re: remove wikisearch from 1.4.x development?

Posted by Christopher <ct...@apache.org>.
On Tue, Nov 19, 2013 at 9:59 AM, Sean Busbey <bu...@clouderagovt.com> wrote:
> On Tue, Nov 19, 2013 at 8:05 AM, Christopher <ct...@apache.org> wrote:
[snip]
> We would expressly not being claiming that wikisearch is a part of our
> public API, correct?

I don't understand this question.

> What kind of testing would be involved for doing a release of the
> wikisearch contrib? Just unit tests as is done with it as part of the 1.4.x
> branch?

Usually, when we do a release, we test that all the examples work
according to the relevant README, not just verify unit tests pass in
the build.

> Would the releases from the contrib repo need to have version numbers that
> match the 1.4.x line, or would a compatibility statement for each release
> be sufficient?

Well, Wikisearch has already been released as 1.4.0, 1.4.1, 1.4.2,
1.4.3, and 1.4.4. Now that it's a sub-project, we don't need to
continue versioning together if it will work with multiple versions,
but it could be confusing if it didn't. Imagine 1.4.4 WS is compatible
with 1.4.5 ACC, but then 1.4.6 introduces a change that causes us to
bump WS... now 1.4.5 WS is needed for 1.4.6 ACC, but won't work on
1.4.5 ACC. That's very confusing to users, even with a compatibility
statement.

Since you indicated that changes to Wikisearch 1.4.4 would be needed
to make it compatible with Hadoop 2 in Accumulo 1.4.5, it seems to
make sense to bump it also. Whether we should continue doing this or
not, is a discussion we can have at another time... I can see merits
in both options... but I wouldn't want to change the convention on a
bugfix/minor release even if we do agree to separate the versioning in
the future.

--
Christopher L Tubbs II
http://gravatar.com/ctubbsii

Re: remove wikisearch from 1.4.x development?

Posted by Sean Busbey <bu...@clouderagovt.com>.
On Tue, Nov 19, 2013 at 8:05 AM, Christopher <ct...@apache.org> wrote:

> It seems like consensus was not really reached on the issue. I don't
> have a very strong opinion on this, but it does seem that changing the
> packaging for 1.4.x for a bugfix release in a major way like this is
> not really a nice thing to do to users.
>
> There's a risk users will have based code agaisnt 1.4.x on this
> example, and it wouldn't be good to break it. At the very least,
> keeping the example in there (and not modifying the way it uses the
> public API), acts as a test, to ensure that we don't make any changes
> that makes 1.4.x user code incompatible with the latest 1.4.x
> development, when they've based their code on what we've suggested
> through our examples.
>
> Since a version of wikisearch has been released with 1.4.4, and we
> already have a separate git repo for wikisearch development, I would
> be okay dropping it from the main repo's 1.4.5-SNAPSHOT branch, if we
> were willing to continue releasing wikisearch from its own repo to
> keep it working with the latest 1.4.x whenever we release accumulo
> 1.4.x.
>
> In other words, it doesn't have to exist in the 1.4.x branch, but it
> should still follow the 1.4.x releases, being released from the
> contrib repo, keeping in line with the packaging precedent for the 1.4
> series.
>
>
>
We would expressly not being claiming that wikisearch is a part of our
public API, correct?

What kind of testing would be involved for doing a release of the
wikisearch contrib? Just unit tests as is done with it as part of the 1.4.x
branch?

Would the releases from the contrib repo need to have version numbers that
match the 1.4.x line, or would a compatibility statement for each release
be sufficient?

-- 
Sean