[GitHub] [tvm] comaniac commented on pull request #8372: [Build] Add CUDA_VERSION and GIT_COMMIT_TIME

[GitBox <gi...@apache.org>]

comaniac commented on pull request #8372:
URL: https://github.com/apache/tvm/pull/8372#issuecomment-871045081


   > > Just curious, if a TVM binary fails at loading time due to inconsistent CUDA versions, I imagine we cannot query via libinfo because loading has already failed. Do we have to consider this particular case?
   
   It seems out of scope to me. It's more like an environment issue if the binary is incompatible and results in loading failure. The only goal of libinfo is reporting the information of the current binary as a part of the environment logging. If we want to provide the information when failed to load, we should do that in other places such as dlopen.
   
   > Reasonable. The cuda version linked at build time and the cuda version in runtime environment when using tvm python package may be different.
   > 
   > Will it be better to rename this to BINARY_CUDA_VERSION or something like cuda version in build time? @comaniac 
   
   I would prefer to keep the current one for 2 reasons. First, this is under support.libinfo, which already clearly says this is for the TVM lib instead of the runtime. Second, it consists with LLVM_VERSION.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org