You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/09 07:09:45 UTC

[GitHub] [flink] leonardBang commented on a change in pull request #12858: [FLINK-18534][kafka][table] Fix unstable KafkaTableITCase.testKafkaDebeziumChangelogSource

leonardBang commented on a change in pull request #12858:
URL: https://github.com/apache/flink/pull/12858#discussion_r452008503



##########
File path: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableTestBase.java
##########
@@ -46,7 +46,7 @@
 @RunWith(Parameterized.class)
 public abstract class KafkaTableTestBase extends KafkaTestBaseWithFlink {
 
-	private static final String JSON_FORMAT = "json";
+	protected static final String JSON_FORMAT = "json";

Review comment:
       How about add format: 
   ```	
   protected static final String DEBEZIUM_JSON = "debezium-json";
   ....
   //add parameters
   new Object[]{false, DEBEZIUM_JSON}
   ...
   	@Test
   	public void testKafkaSourceSink() throws Exception {
   		if (DEBEZIUM_JSON.equals(format)) {
   			// skip debezium json format
   			return;
   		}
          ....
   ```
   And then the testKafkaDebeziumChangelogSource will be more clear like:
   ```
   if (isLegacyConnector || !DEBEZIUM_JSON.equals(format)) {
   			// skip tests for legacy connector, because changelog source is only supported in new connector
   			return;
   		}
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org