You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Bram de Kruijff (JIRA)" <ji...@apache.org> on 2006/09/01 18:47:23 UTC
[jira] Created: (FELIX-137) ServiceDependency fails to invoke
callback methods when implemented in superclass (patch included)
ServiceDependency fails to invoke callback methods when implemented in superclass (patch included)
--------------------------------------------------------------------------------------------------
Key: FELIX-137
URL: http://issues.apache.org/jira/browse/FELIX-137
Project: Felix
Issue Type: Bug
Components: Dependency Manager
Affects Versions: 0.8.0
Reporter: Bram de Kruijff
Attachments: ServiceDependency_patch1.txt, ServiceDependency_patch2.txt
ServiceDependency fails to invoke callback methods when implemented in superclass. The problem is in the invokeCallbackMethod method cause it will never loop. I include 2 patches. The first just fixes the loop, but I was wondering why getDeclaredMethod is used. Using getMethod instead seems to work just fine.
grz,
Bram
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (FELIX-137) ServiceDependency fails to invoke
callback methods when implemented in superclass (patch included)
Posted by "Bram de Kruijff (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FELIX-137?page=all ]
Bram de Kruijff updated FELIX-137:
----------------------------------
Attachment: ServiceDependency.java.patch
fix for multiple callbacks
* removes recursion
* changes approach to breadth first
> ServiceDependency fails to invoke callback methods when implemented in superclass (patch included)
> --------------------------------------------------------------------------------------------------
>
> Key: FELIX-137
> URL: http://issues.apache.org/jira/browse/FELIX-137
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: 0.8.0
> Reporter: Bram de Kruijff
> Assigned To: Marcel Offermans
> Fix For: 0.8.0
>
> Attachments: ServiceDependency.java.patch, ServiceDependency_patch1.txt, ServiceDependency_patch2.txt
>
>
> ServiceDependency fails to invoke callback methods when implemented in superclass. The problem is in the invokeCallbackMethod method cause it will never loop. I include 2 patches. The first just fixes the loop, but I was wondering why getDeclaredMethod is used. Using getMethod instead seems to work just fine.
> grz,
> Bram
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (FELIX-137) ServiceDependency fails to invoke
callback methods when implemented in superclass (patch included)
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FELIX-137?page=all ]
Marcel Offermans resolved FELIX-137.
------------------------------------
Resolution: Fixed
Applied the patch supplied by Bram.
Added one extra option to make sure that the method stops looking for a method if the invoked method itself throws an exception (which means we did find and invoke the method, it just did not complete normally).
> ServiceDependency fails to invoke callback methods when implemented in superclass (patch included)
> --------------------------------------------------------------------------------------------------
>
> Key: FELIX-137
> URL: http://issues.apache.org/jira/browse/FELIX-137
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: 0.8.0
> Reporter: Bram de Kruijff
> Assigned To: Marcel Offermans
> Fix For: 0.8.0
>
> Attachments: ServiceDependency.java.patch, ServiceDependency_patch1.txt, ServiceDependency_patch2.txt
>
>
> ServiceDependency fails to invoke callback methods when implemented in superclass. The problem is in the invokeCallbackMethod method cause it will never loop. I include 2 patches. The first just fixes the loop, but I was wondering why getDeclaredMethod is used. Using getMethod instead seems to work just fine.
> grz,
> Bram
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (FELIX-137) ServiceDependency fails to invoke
callback methods when implemented in superclass (patch included)
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FELIX-137?page=all ]
Marcel Offermans resolved FELIX-137.
------------------------------------
Fix Version/s: 0.8.0
Resolution: Fixed
Just committed a patch that implements a new algorithm to invoke methods in any (super)class.
> ServiceDependency fails to invoke callback methods when implemented in superclass (patch included)
> --------------------------------------------------------------------------------------------------
>
> Key: FELIX-137
> URL: http://issues.apache.org/jira/browse/FELIX-137
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: 0.8.0
> Reporter: Bram de Kruijff
> Assigned To: Marcel Offermans
> Fix For: 0.8.0
>
> Attachments: ServiceDependency_patch1.txt, ServiceDependency_patch2.txt
>
>
> ServiceDependency fails to invoke callback methods when implemented in superclass. The problem is in the invokeCallbackMethod method cause it will never loop. I include 2 patches. The first just fixes the loop, but I was wondering why getDeclaredMethod is used. Using getMethod instead seems to work just fine.
> grz,
> Bram
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (FELIX-137) ServiceDependency fails to invoke
callback methods when implemented in superclass (patch included)
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FELIX-137?page=all ]
Marcel Offermans reassigned FELIX-137:
--------------------------------------
Assignee: Marcel Offermans
> ServiceDependency fails to invoke callback methods when implemented in superclass (patch included)
> --------------------------------------------------------------------------------------------------
>
> Key: FELIX-137
> URL: http://issues.apache.org/jira/browse/FELIX-137
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: 0.8.0
> Reporter: Bram de Kruijff
> Assigned To: Marcel Offermans
> Attachments: ServiceDependency_patch1.txt, ServiceDependency_patch2.txt
>
>
> ServiceDependency fails to invoke callback methods when implemented in superclass. The problem is in the invokeCallbackMethod method cause it will never loop. I include 2 patches. The first just fixes the loop, but I was wondering why getDeclaredMethod is used. Using getMethod instead seems to work just fine.
> grz,
> Bram
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (FELIX-137) ServiceDependency fails to invoke
callback methods when implemented in superclass (patch included)
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall closed FELIX-137.
---------------------------------
> ServiceDependency fails to invoke callback methods when implemented in superclass (patch included)
> --------------------------------------------------------------------------------------------------
>
> Key: FELIX-137
> URL: https://issues.apache.org/jira/browse/FELIX-137
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: 0.8.0
> Reporter: Bram de Kruijff
> Assigned To: Marcel Offermans
> Fix For: 0.8.0
>
> Attachments: ServiceDependency.java.patch, ServiceDependency_patch1.txt, ServiceDependency_patch2.txt
>
>
> ServiceDependency fails to invoke callback methods when implemented in superclass. The problem is in the invokeCallbackMethod method cause it will never loop. I include 2 patches. The first just fixes the loop, but I was wondering why getDeclaredMethod is used. Using getMethod instead seems to work just fine.
> grz,
> Bram
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-137) ServiceDependency fails to invoke
callback methods when implemented in superclass (patch included)
Posted by "Bram de Kruijff (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FELIX-137?page=comments#action_12455957 ]
Bram de Kruijff commented on FELIX-137:
---------------------------------------
It seems now it is all little too enthusiastic :P In my case I now get multiple callbacks on from servicedependencies in the same scenario. The problem is in the recursive invokeMethod that takes a depth first approach and doesn't stop when it's done. I'll attach a new patch to this problem. It's non-recursive and breadth first.. I like it :)
> ServiceDependency fails to invoke callback methods when implemented in superclass (patch included)
> --------------------------------------------------------------------------------------------------
>
> Key: FELIX-137
> URL: http://issues.apache.org/jira/browse/FELIX-137
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: 0.8.0
> Reporter: Bram de Kruijff
> Assigned To: Marcel Offermans
> Fix For: 0.8.0
>
> Attachments: ServiceDependency_patch1.txt, ServiceDependency_patch2.txt
>
>
> ServiceDependency fails to invoke callback methods when implemented in superclass. The problem is in the invokeCallbackMethod method cause it will never loop. I include 2 patches. The first just fixes the loop, but I was wondering why getDeclaredMethod is used. Using getMethod instead seems to work just fine.
> grz,
> Bram
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FELIX-137) ServiceDependency fails to invoke
callback methods when implemented in superclass (patch included)
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FELIX-137?page=comments#action_12432358 ]
Marcel Offermans commented on FELIX-137:
----------------------------------------
Thanks for the patches, Bram! I'm going to combine them to make sure that callbacks are found regardless of their exact location. getDeclaredMethod() was used because it can also find non-public methods (which getMethod() can't) but on the other hand, getDeclaredMethod() cannot find methods in superclasses. I would really want both, so I'll come up with a patch that does just that.
> ServiceDependency fails to invoke callback methods when implemented in superclass (patch included)
> --------------------------------------------------------------------------------------------------
>
> Key: FELIX-137
> URL: http://issues.apache.org/jira/browse/FELIX-137
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: 0.8.0
> Reporter: Bram de Kruijff
> Attachments: ServiceDependency_patch1.txt, ServiceDependency_patch2.txt
>
>
> ServiceDependency fails to invoke callback methods when implemented in superclass. The problem is in the invokeCallbackMethod method cause it will never loop. I include 2 patches. The first just fixes the loop, but I was wondering why getDeclaredMethod is used. Using getMethod instead seems to work just fine.
> grz,
> Bram
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (FELIX-137) ServiceDependency fails to invoke
callback methods when implemented in superclass (patch included)
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FELIX-137?page=all ]
Marcel Offermans reopened FELIX-137:
------------------------------------
Still not correctly implemented, incorporate Bram's fixes.
> ServiceDependency fails to invoke callback methods when implemented in superclass (patch included)
> --------------------------------------------------------------------------------------------------
>
> Key: FELIX-137
> URL: http://issues.apache.org/jira/browse/FELIX-137
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: 0.8.0
> Reporter: Bram de Kruijff
> Assigned To: Marcel Offermans
> Fix For: 0.8.0
>
> Attachments: ServiceDependency.java.patch, ServiceDependency_patch1.txt, ServiceDependency_patch2.txt
>
>
> ServiceDependency fails to invoke callback methods when implemented in superclass. The problem is in the invokeCallbackMethod method cause it will never loop. I include 2 patches. The first just fixes the loop, but I was wondering why getDeclaredMethod is used. Using getMethod instead seems to work just fine.
> grz,
> Bram
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira