You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/16 08:58:15 UTC

[GitHub] [spark] viirya commented on a change in pull request #31572: [SPARK-34446][SS][DOCS] Update doc for stream-stream join (full outer + left semi)

viirya commented on a change in pull request #31572:
URL: https://github.com/apache/spark/pull/31572#discussion_r576650948



##########
File path: docs/structured-streaming-programming-guide.md
##########
@@ -1337,7 +1337,7 @@ impressionsWithWatermark.join(
     clickTime >= impressionTime AND
     clickTime <= impressionTime + interval 1 hour
     """),
-  joinType = "leftOuter"      // can be "inner", "leftOuter", "rightOuter"
+  joinType = "leftOuter"      // can be "inner", "leftOuter", "rightOuter", "fullOuter", "leftSemi"

Review comment:
       Not due to this PR, but I saw this section is "Outer Joins with Watermarking", seems to be "inner" and "leftSemi" should not be here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org