You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/08/03 07:48:53 UTC
[GitHub] zeppelin pull request #1273: [Zeppelin-1276] Fix Notebook Title Input
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1273
[Zeppelin-1276] Fix Notebook Title Input
### What is this PR for?
The Notebook Title Input would not disappear after being edited.
This is a problem made by its plugin elastic-input.
We originally used ng-if instead of ng-show so it doesn't break the Page Print, however that change made the scope value to toggle unusable.
So we added a trustworthy small controller on top of the component.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1276
### How should this be tested?
* Click on the Notebook title
* Try to do: Enter or Esc or Click somewhere else
* The Input border should not be there anymore
* Do the same for the Paragraph
* If you do Print Page there shouldn't any titles duplicated at the top
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1276
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1273
----
commit b862081c8b74632fc472fe45911a8cffbbdc7d12
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-03T07:34:43Z
Fix Notebook input issue
commit d590d825de002bfe519a5859683e4e2c1de464c9
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-03T07:39:43Z
apply same input changes to the paragraph
commit 24df51f684c5caf97d3ef9d646afe30defc2aedb
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-03T07:43:10Z
Fix eslint errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1273: [Zeppelin-1276] Fix Notebook Title Input
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1273
Tried locally and renaming notebook works now as expected.
Looks great to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1273: [Zeppelin-1276] Fix Notebook Title Input
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1273: [Zeppelin-1276] Fix Notebook Title Input
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1273: [Zeppelin-1276] Fix Notebook Title Input
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1273
Trigger CI again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1273: [Zeppelin-1276] Fix Notebook Title Input
Posted by corneadoug <gi...@git.apache.org>.
GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1273
[Zeppelin-1276] Fix Notebook Title Input
### What is this PR for?
The Notebook Title Input would not disappear after being edited.
This is a problem made by its plugin elastic-input.
We originally used ng-if instead of ng-show so it doesn't break the Page Print, however that change made the scope value to toggle unusable.
So we added a trustworthy small controller on top of the component.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1276
### How should this be tested?
* Click on the Notebook title
* Try to do: Enter or Esc or Click somewhere else
* The Input border should not be there anymore
* Do the same for the Paragraph
* If you do Print Page there shouldn't any titles duplicated at the top
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1276
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1273
----
commit b862081c8b74632fc472fe45911a8cffbbdc7d12
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-03T07:34:43Z
Fix Notebook input issue
commit d590d825de002bfe519a5859683e4e2c1de464c9
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-03T07:39:43Z
apply same input changes to the paragraph
commit 24df51f684c5caf97d3ef9d646afe30defc2aedb
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-03T07:43:10Z
Fix eslint errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1273: [Zeppelin-1276] Fix Notebook Title Input
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1273
Alright, CI is mainly green now. Only one Build Profile failing on Spark.
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---