You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Adam Tamas (Code Review)" <ge...@cloudera.org> on 2020/04/20 22:11:58 UTC

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

Adam Tamas has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15766


Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert
......................................................................

IMPALA-9665: Fixed database not found errors in query_test.test_insert

Fixed the usage of the unique_database in the test_insert.py  to wait with the
tests until the database is synced.

Testing:
-tests/run-tests.py query_test/test_insert.py --exploration_strategy=exhaustive

Change-Id: I9b7aa3775dd4375f536d76f2e236ce126f8c78cd
---
M tests/query_test/test_insert.py
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/15766/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b7aa3775dd4375f536d76f2e236ce126f8c78cd
Gerrit-Change-Number: 15766
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15766 )

Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5838/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b7aa3775dd4375f536d76f2e236ce126f8c78cd
Gerrit-Change-Number: 15766
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2020 22:59:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15766 )

Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert
......................................................................

IMPALA-9665: Fixed database not found errors in query_test.test_insert

Fixed the usage of the unique_database in the test_insert.py  to wait with the
tests until the database is synced.

Testing:
-tests/run-tests.py query_test/test_insert.py --exploration_strategy=exhaustive

Change-Id: I9b7aa3775dd4375f536d76f2e236ce126f8c78cd
Reviewed-on: http://gerrit.cloudera.org:8080/15766
Reviewed-by: Andrew Sherman <as...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_insert.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Andrew Sherman: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b7aa3775dd4375f536d76f2e236ce126f8c78cd
Gerrit-Change-Number: 15766
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15766 )

Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b7aa3775dd4375f536d76f2e236ce126f8c78cd
Gerrit-Change-Number: 15766
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 06:12:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15766 )

Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5681/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b7aa3775dd4375f536d76f2e236ce126f8c78cd
Gerrit-Change-Number: 15766
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 01:52:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15766 )

Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert
......................................................................


Patch Set 1:

Looks good, will wait for build to run.
Gerrit says "Cannot Merge" so you may need to rebase.


-- 
To view, visit http://gerrit.cloudera.org:8080/15766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b7aa3775dd4375f536d76f2e236ce126f8c78cd
Gerrit-Change-Number: 15766
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2020 22:51:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15766 )

Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert
......................................................................


Patch Set 2: Code-Review+2

LGTM


-- 
To view, visit http://gerrit.cloudera.org:8080/15766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b7aa3775dd4375f536d76f2e236ce126f8c78cd
Gerrit-Change-Number: 15766
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 01:51:09 +0000
Gerrit-HasComments: No