You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Peter Wages (JIRA)" <ji...@apache.org> on 2008/04/22 16:59:05 UTC
[jira] Created: (WW-2610) checkfielderror.ftl does not highlight
select tag errors in yellow
checkfielderror.ftl does not highlight select tag errors in yellow
---------------------------------------------------------------------
Key: WW-2610
URL: https://issues.apache.org/struts/browse/WW-2610
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.0.9
Environment: Windows XP , Eclipse
Reporter: Peter Wages
Whereas checkfielderror.ftl of the simple theme will find field errors for a textfield and change the background to yellow. It will not do so for select tags. The error message for the select tags show up so the theme knows about the errors. It would seem that the fielderrors array/list is removed or dis appears.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2610) checkfielderror.ftl does not highlight
select tag errors in yellow
Posted by "Peter Wages (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Wages updated WW-2610:
----------------------------
Priority: Minor (was: Major)
> checkfielderror.ftl does not highlight select tag errors in yellow
> ---------------------------------------------------------------------
>
> Key: WW-2610
> URL: https://issues.apache.org/struts/browse/WW-2610
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Environment: Windows XP , Eclipse
> Reporter: Peter Wages
> Priority: Minor
>
> Whereas checkfielderror.ftl of the simple theme will find field errors for a textfield and change the background to yellow. It will not do so for select tags. The error message for the select tags show up so the theme knows about the errors. It would seem that the fielderrors array/list is removed or dis appears.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2610) checkfielderror.ftl does not highlight
select tag errors in yellow
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso resolved WW-2610.
---------------------------------
Resolution: Fixed
Fixed in trunk rv719021. Thanks for reporting and the patch!
> checkfielderror.ftl does not highlight select tag errors in yellow
> ---------------------------------------------------------------------
>
> Key: WW-2610
> URL: https://issues.apache.org/struts/browse/WW-2610
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Environment: Windows XP , Eclipse
> Reporter: Peter Wages
> Priority: Minor
> Fix For: 2.1.3
>
> Attachments: css.ftl
>
>
> Whereas checkfielderror.ftl of the simple theme will find field errors for a textfield and change the background to yellow. It will not do so for select tags. The error message for the select tags show up so the theme knows about the errors. It would seem that the fielderrors array/list is removed or dis appears.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2610) checkfielderror.ftl does not highlight
select tag errors in yellow
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-2610:
--------------------------
Fix Version/s: 2.1.3
> checkfielderror.ftl does not highlight select tag errors in yellow
> ---------------------------------------------------------------------
>
> Key: WW-2610
> URL: https://issues.apache.org/struts/browse/WW-2610
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Environment: Windows XP , Eclipse
> Reporter: Peter Wages
> Priority: Minor
> Fix For: 2.1.3
>
>
> Whereas checkfielderror.ftl of the simple theme will find field errors for a textfield and change the background to yellow. It will not do so for select tags. The error message for the select tags show up so the theme knows about the errors. It would seem that the fielderrors array/list is removed or dis appears.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2610) checkfielderror.ftl does not highlight
select tag errors in yellow
Posted by "Gabriel Belingueres (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gabriel Belingueres updated WW-2610:
------------------------------------
Attachment: css.ftl
Now, when there is a validation error and it is defined either cssErrorClass or cssErrorStyle, then the cssStyle is not written.
> checkfielderror.ftl does not highlight select tag errors in yellow
> ---------------------------------------------------------------------
>
> Key: WW-2610
> URL: https://issues.apache.org/struts/browse/WW-2610
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Environment: Windows XP , Eclipse
> Reporter: Peter Wages
> Priority: Minor
> Fix For: 2.1.3
>
> Attachments: css.ftl
>
>
> Whereas checkfielderror.ftl of the simple theme will find field errors for a textfield and change the background to yellow. It will not do so for select tags. The error message for the select tags show up so the theme knows about the errors. It would seem that the fielderrors array/list is removed or dis appears.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2610) checkfielderror.ftl does not
highlight select tag errors in yellow
Posted by "Gabriel Belingueres (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44714#action_44714 ]
Gabriel Belingueres commented on WW-2610:
-----------------------------------------
Indeed I see (in S2.1.2) that there are times where an cssErrorClass is not taken into account by the web browser because style attributes take precedence.
Ex:
<style type="text/css">
<!--
.myok { background-color: green }
.myerror { background-color: yellow }
-->
</style>
> checkfielderror.ftl does not highlight select tag errors in yellow
> ---------------------------------------------------------------------
>
> Key: WW-2610
> URL: https://issues.apache.org/struts/browse/WW-2610
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Environment: Windows XP , Eclipse
> Reporter: Peter Wages
> Priority: Minor
> Fix For: 2.1.3
>
>
> Whereas checkfielderror.ftl of the simple theme will find field errors for a textfield and change the background to yellow. It will not do so for select tags. The error message for the select tags show up so the theme knows about the errors. It would seem that the fielderrors array/list is removed or dis appears.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2610) checkfielderror.ftl does not
highlight select tag errors in yellow
Posted by "Gabriel Belingueres (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44715#action_44715 ]
Gabriel Belingueres commented on WW-2610:
-----------------------------------------
sorry wrong button :P
<style type="text/css">
<!--
.myok { background-color: green }
.myerror { background-color: yellow }
-->
</style>
...
<s:form ... theme="simple">
<s:textfield name="t" cssStyle="background-color: green" cssErrorClass="myerror"/>
<s:select name="xxx" cssStyle="background-color: green" cssErrorClass="myerror" list="somelist" size="1" />
...
when validation error occurs, the generated markup is:
<input type="text" name="t" ... class="myerror" style="background-color: green"/>
here the background is green because the style attribute is present.
I think I can send a fix in a few days.
> checkfielderror.ftl does not highlight select tag errors in yellow
> ---------------------------------------------------------------------
>
> Key: WW-2610
> URL: https://issues.apache.org/struts/browse/WW-2610
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Environment: Windows XP , Eclipse
> Reporter: Peter Wages
> Priority: Minor
> Fix For: 2.1.3
>
>
> Whereas checkfielderror.ftl of the simple theme will find field errors for a textfield and change the background to yellow. It will not do so for select tags. The error message for the select tags show up so the theme knows about the errors. It would seem that the fielderrors array/list is removed or dis appears.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.