You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@community.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2015/07/13 20:55:05 UTC

[jira] [Resolved] (COMDEV-147) scandist.py issues

     [ https://issues.apache.org/jira/browse/COMDEV-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved COMDEV-147.
-------------------------
    Resolution: Fixed

URL: http://svn.apache.org/r1690782
Log:
COMDEV-147 scandist.py issues
Now scans all files in the commit (but only sends one e-mail)
The mail message now contains the SVN revision as well as the log message

Modified:
    comdev/reporter.apache.org/trunk/scandist.py

> scandist.py issues
> ------------------
>
>                 Key: COMDEV-147
>                 URL: https://issues.apache.org/jira/browse/COMDEV-147
>             Project: Community Development
>          Issue Type: Bug
>          Components: Reporter Tool
>            Reporter: Sebb
>
> The scandist.py script currently only checks the first 'changed' entry to see if the path is of interest. It is possible (though rather unlikely) that a single commit may involve more than one path. It probably ought to check all the paths.
> The script assumes that all commits are additions, so will send an e-mail when the committer is tidying up old releases. That can be confusing for the committer, especially since the e-mail does not provide any details of the commit (no revision id, no log message).
> The code also currently stores changes in the 'targets' dict using the committer id as the key. Only a single entry is stored for each committer.
> Now the mailer method that uses the 'targets' dict only runs every 5 minutes, so changes can potentially be lost.
> Workitems for the mailer process need to be accumulated, not overwritten.
> The workitem also needs to include more details, such as the log message and the commit revision, to make it easier for committers on projects with multiple products such as Commons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)