You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sodonnel (via GitHub)" <gi...@apache.org> on 2023/02/24 12:27:56 UTC
[GitHub] [ozone] sodonnel opened a new pull request, #4313: HDDS-8025. ReplicationManager: Count a container once for missing, under, mis or over replicated
sodonnel opened a new pull request, #4313:
URL: https://github.com/apache/ozone/pull/4313
## What changes were proposed in this pull request?
If a container is missing, then the new Replication Manager currently counts 1 in the report for under replicated and 1 for missing, meaning the container is double counted.
It makes more sense if we only count under-replicated OR missing. Technically a missing container is also under-replicated, but it makes the report confusing when the container is in two states.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8025
## How was this patch tested?
Modified some existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on pull request #4313: HDDS-8025. ReplicationManager: Count a container once for missing, under, mis or over replicated
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on PR #4313:
URL: https://github.com/apache/ozone/pull/4313#issuecomment-1443943327
> @sodonnel some test failure in re-run looks related:
>
> ```
> TestReplicationManager.testUnderReplicatedAndUnrecoverable:433 expected:<1> but was:<0>
> TestReplicationManager.testUnrecoverableClosedContainerWithUnhealthyReplicas:495 expected:<1> but was:<0>
> ```
>
> https://github.com/apache/ozone/actions/runs/4262416097/jobs/7419698367#step:6:1474
Yea I missed those ones. Easy to fix so I have pushed a new commit now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4313: HDDS-8025. ReplicationManager: Count a container once for missing, under, mis or over replicated
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4313:
URL: https://github.com/apache/ozone/pull/4313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4313: HDDS-8025. ReplicationManager: Count a container once for missing, under, mis or over replicated
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4313:
URL: https://github.com/apache/ozone/pull/4313#issuecomment-1443782812
@sodonnel some test failure in re-run looks related:
```
TestReplicationManager.testUnderReplicatedAndUnrecoverable:433 expected:<1> but was:<0>
TestReplicationManager.testUnrecoverableClosedContainerWithUnhealthyReplicas:495 expected:<1> but was:<0>
```
https://github.com/apache/ozone/actions/runs/4262416097/jobs/7419698367#step:6:1474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org