You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2022/10/24 08:11:40 UTC

[camel] 01/02: CAMEL-18640: camel-console - Stacktraces in json response should be as array

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 1e720577f568985f3c003e8ca2c9d26c4d855b7f
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Mon Oct 24 06:21:45 2022 +0200

    CAMEL-18640: camel-console - Stacktraces in json response should be as array
---
 .../java/org/apache/camel/impl/console/HealthDevConsole.java     | 9 +++++----
 .../apache/camel/support/processor/DefaultExchangeFormatter.java | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/core/camel-console/src/main/java/org/apache/camel/impl/console/HealthDevConsole.java b/core/camel-console/src/main/java/org/apache/camel/impl/console/HealthDevConsole.java
index 727f86360b7..791d8c7186f 100644
--- a/core/camel-console/src/main/java/org/apache/camel/impl/console/HealthDevConsole.java
+++ b/core/camel-console/src/main/java/org/apache/camel/impl/console/HealthDevConsole.java
@@ -109,10 +109,11 @@ public class HealthDevConsole extends AbstractDevConsole {
 
                 Throwable cause = res.getError().orElse(null);
                 if (cause != null) {
-                    StringWriter sw = new StringWriter();
-                    PrintWriter pw = new PrintWriter(sw);
-                    cause.printStackTrace(pw);
-                    jo.put("stacktrace", pw.toString());
+                    StringWriter writer = new StringWriter();
+                    cause.printStackTrace(new PrintWriter(writer));
+                    writer.flush();
+                    String stacktrace = writer.toString();
+                    jo.put("stacktrace", stacktrace);
                 }
             }
 
diff --git a/core/camel-support/src/main/java/org/apache/camel/support/processor/DefaultExchangeFormatter.java b/core/camel-support/src/main/java/org/apache/camel/support/processor/DefaultExchangeFormatter.java
index 7d42ae6ab67..ceea457b93c 100644
--- a/core/camel-support/src/main/java/org/apache/camel/support/processor/DefaultExchangeFormatter.java
+++ b/core/camel-support/src/main/java/org/apache/camel/support/processor/DefaultExchangeFormatter.java
@@ -197,7 +197,7 @@ public class DefaultExchangeFormatter implements ExchangeFormatter {
                 if (showAll || showStackTrace) {
                     StringWriter sw = new StringWriter();
                     exception.printStackTrace(new PrintWriter(sw));
-                    style(sb, "StackTrace").append(sw.toString());
+                    style(sb, "StackTrace").append(sw);
                 }
             }
         }