You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Vincent Siveton <vi...@gmail.com> on 2009/01/16 14:31:49 UTC

Re: svn commit: r734324 - /maven/mercury/trunk/mercury-plexus/src/main/java/org/apache/maven/mercury/plexus/DefaultPlexusMercury.java

Hi Oleg,

2009/1/13, ogusakov@apache.org <og...@apache.org>:
> Author: ogusakov
>  Date: Tue Jan 13 20:34:49 2009
>  New Revision: 734324
>
>  URL: http://svn.apache.org/viewvc?rev=734324&view=rev
>  Log:
>  [MNG-3981] fixed a bug

I love this idea to add the related issue number on each commit: it is
definitely a good improvement. But, specifying the description of the
issue is better to understand the related issue: we don't need to
search the issue on jira :)

>        ArtifactBasicResults res = vr.readVersions( q );
>  +
>  +      if( res == null )
>  +          return null;
>

Also, could you respect our code style?

Thanks!

Vincent

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org