You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/11 12:19:45 UTC

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #1148: feat: remove canvas & add schema

1502shivam-singh commented on PR #1148:
URL: https://github.com/apache/apisix-website/pull/1148#issuecomment-1152916298

   > With Canvas -
   
   ![image](https://user-images.githubusercontent.com/57267960/173187359-6b904a2b-85f6-4bce-aeb0-785ecacb8822.png)
   
   > Without Canvas -
   
   ![image](https://user-images.githubusercontent.com/57267960/173187371-0f96025e-a38a-471f-a8af-042471f8b433.png)
   
   Not a performance boost tbh (even if lighthouse might not be the most reliable). Also, the return from this big change isn't the most beneficial.
   About performance issues, just to mention here, I had created a system to stop rendering on both canvases when they were not visible on the browser viewport, to squeeze out the most performance boost. 
   So, **I won't recommend** this change to take place, as it does more harm than good to the overall visual style and doesn't provide a huge chunk of performance boost anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org