You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Alan Carroll <so...@oath.com.INVALID> on 2018/03/21 15:35:48 UTC
Adding CMakeLists.txt to TS root for editor support
A number of developers are now using editors (Visual Code, CLion) that
depend on have a CMakeLists.txt to describe all the source code. How much
objection would there be to putting this file in the root of the source
tree purely for editor support, without worrying about whether it can
actually build TS.
Re: Adding CMakeLists.txt to TS root for editor support
Posted by Alan Carroll <so...@oath.com.INVALID>.
PR 3342.
On Sun, Mar 25, 2018 at 2:01 PM, Leif Hedstrom <zw...@apache.org> wrote:
>
>
> > On Mar 21, 2018, at 10:17 AM, Alan Carroll <so...@oath.com.INVALID>
> wrote:
> >
> > To answer both of you, you can put comments in the file so we can
> >
> > 1) Make RAT happy.
> > 2) Make it clear it's just an editor support file, not a real make file.
> >
>
>
> Yeh seems fine, as long as we don’t switch to cmake for the builds :-).
>
> Cheers,
>
> — leif
>
>
>
Re: Adding CMakeLists.txt to TS root for editor support
Posted by Leif Hedstrom <zw...@apache.org>.
> On Mar 21, 2018, at 10:17 AM, Alan Carroll <so...@oath.com.INVALID> wrote:
>
> To answer both of you, you can put comments in the file so we can
>
> 1) Make RAT happy.
> 2) Make it clear it's just an editor support file, not a real make file.
>
Yeh seems fine, as long as we don’t switch to cmake for the builds :-).
Cheers,
— leif
Re: Adding CMakeLists.txt to TS root for editor support
Posted by Alan Carroll <so...@oath.com.INVALID>.
To answer both of you, you can put comments in the file so we can
1) Make RAT happy.
2) Make it clear it's just an editor support file, not a real make file.
On Wed, Mar 21, 2018 at 11:02 AM, Walt Karas <wk...@oath.com.invalid>
wrote:
> Is rat ci going to complain it has no license?
>
> On Wed, Mar 21, 2018 at 10:44 AM, Derek Dagit <de...@oath.com.invalid>
> wrote:
> > If we can put a comment in the file to say as much, I think it would be
> OK.
> >
> > I would like to avoid confusion around whether this is sufficient or
> > required to build independent of these other tools—it would be good to
> have
> > something about its status and what it is intended for.
> >
> > I support making life easier for developers by committing such things to
> > the repo, even if I don't use those tools.
> >
> > On Wed, Mar 21, 2018 at 10:35 AM, Alan Carroll <
> > solidwallofcode@oath.com.invalid> wrote:
> >
> >> A number of developers are now using editors (Visual Code, CLion) that
> >> depend on have a CMakeLists.txt to describe all the source code. How
> much
> >> objection would there be to putting this file in the root of the source
> >> tree purely for editor support, without worrying about whether it can
> >> actually build TS.
> >>
> >
> >
> >
> > --
> > Derek
>
Re: Adding CMakeLists.txt to TS root for editor support
Posted by Walt Karas <wk...@oath.com.INVALID>.
Is rat ci going to complain it has no license?
On Wed, Mar 21, 2018 at 10:44 AM, Derek Dagit <de...@oath.com.invalid> wrote:
> If we can put a comment in the file to say as much, I think it would be OK.
>
> I would like to avoid confusion around whether this is sufficient or
> required to build independent of these other tools—it would be good to have
> something about its status and what it is intended for.
>
> I support making life easier for developers by committing such things to
> the repo, even if I don't use those tools.
>
> On Wed, Mar 21, 2018 at 10:35 AM, Alan Carroll <
> solidwallofcode@oath.com.invalid> wrote:
>
>> A number of developers are now using editors (Visual Code, CLion) that
>> depend on have a CMakeLists.txt to describe all the source code. How much
>> objection would there be to putting this file in the root of the source
>> tree purely for editor support, without worrying about whether it can
>> actually build TS.
>>
>
>
>
> --
> Derek
Re: Adding CMakeLists.txt to TS root for editor support
Posted by Derek Dagit <de...@oath.com.INVALID>.
If we can put a comment in the file to say as much, I think it would be OK.
I would like to avoid confusion around whether this is sufficient or
required to build independent of these other tools—it would be good to have
something about its status and what it is intended for.
I support making life easier for developers by committing such things to
the repo, even if I don't use those tools.
On Wed, Mar 21, 2018 at 10:35 AM, Alan Carroll <
solidwallofcode@oath.com.invalid> wrote:
> A number of developers are now using editors (Visual Code, CLion) that
> depend on have a CMakeLists.txt to describe all the source code. How much
> objection would there be to putting this file in the root of the source
> tree purely for editor support, without worrying about whether it can
> actually build TS.
>
--
Derek