You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2012/04/23 23:41:55 UTC
Re: svn commit: r1329404 - in /subversion/trunk/subversion:
include/private/ libsvn_client/ libsvn_wc/
On Mon, Apr 23, 2012 at 15:44, <ju...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/include/private/svn_wc_private.h Mon Apr 23 19:44:31 2012
> @@ -628,21 +628,31 @@ svn_wc__node_has_working(svn_boolean_t *
>
>
> /**
> - * Get the base revision of @a local_abspath using @a wc_ctx. If
> - * @a local_abspath is not in the working copy, return
> - * @c SVN_ERR_WC_PATH_NOT_FOUND.
> + * Get the repository location of the base node at @a local_abspath.
> *
> - * In @a *base_revision, return the revision of the revert-base, i.e. the
> - * revision that this node was checked out at or last updated/switched to,
> + * Set *REVISION, *REPOS_RELPATH, *REPOS_ROOT_URL and *REPOS_UUID to the
> + * location that this node was checked out at or last updated/switched to,
> * regardless of any uncommitted changes (delete, replace and/or
> * copy-here/move-here). For a locally added/copied/moved-here node that is
> - * not part of a replace, return @c SVN_INVALID_REVNUM.
> + * not part of a replace, return @c SVN_INVALID_REVNUM/NULL/NULL/NULL.
> + *
> + * If there is no base node at @a local_abspath, return a
> + * @c SVN_ERR_WC_PATH_NOT_FOUND error.
The implementation does not support this. That error is never returned.
>...
Cheers,
-g
Re: svn commit: r1329404 - in /subversion/trunk/subversion: include/private/ libsvn_client/ libsvn_wc/
Posted by Julian Foad <ju...@btopenworld.com>.
Greg Stein wrote:
> On Mon, Apr 23, 2012 at 15:44, <ju...@apache.org> wrote:
>> - * In @a *base_revision, return the revision of the revert-base, i.e. the
>> - * revision that this node was checked out at or last updated/switched to,
>> + * Set *REVISION, *REPOS_RELPATH, *REPOS_ROOT_URL and *REPOS_UUID to the
>> + * location that this node was checked out at or last updated/switched to,
>> * regardless of any uncommitted changes (delete, replace and/or
>> * copy-here/move-here). For a locally added/copied/moved-here node that is
>> - * not part of a replace, return @c SVN_INVALID_REVNUM.
>> + * not part of a replace, return @c SVN_INVALID_REVNUM/NULL/NULL/NULL.
>> + *
>> + * If there is no base node at @a local_abspath, return a
>> + * @c SVN_ERR_WC_PATH_NOT_FOUND error.
>
> The implementation does not support this. That error is never returned.
Oh yes, thanks for spotting that mistake.
Fixed in r1329573.
- Julian