You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/09 16:05:40 UTC
[GitHub] [nifi-minifi-cpp] adam-markovics opened a new pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties
adam-markovics opened a new pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282
Hotfix, test coverage is still being developed, that will take at least one more day.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r822915267
##########
File path: extensions/rocksdb-repos/ProvenanceRepository.h
##########
@@ -72,7 +72,7 @@ class ProvenanceRepository : public core::Repository, public std::enable_shared_
if (running_)
return;
running_ = true;
- thread_ = std::thread(&ProvenanceRepository::run, shared_from_this());
+ thread_ = std::thread(&ProvenanceRepository::run, this);
Review comment:
I can confirm that this fixes the ProvenanceRepository crash. Are the tests going to be in this pull request, or in a separate one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties
Posted by GitBox <gi...@apache.org>.
adam-markovics commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r822937105
##########
File path: extensions/rocksdb-repos/ProvenanceRepository.h
##########
@@ -72,7 +72,7 @@ class ProvenanceRepository : public core::Repository, public std::enable_shared_
if (running_)
return;
running_ = true;
- thread_ = std::thread(&ProvenanceRepository::run, shared_from_this());
+ thread_ = std::thread(&ProvenanceRepository::run, this);
Review comment:
They are supposed to be in this one. Unless it is urgent to merge, then it's free to merge and then I'll open another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties
Posted by GitBox <gi...@apache.org>.
adam-markovics commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r824444699
##########
File path: docker/test/integration/resources/minifi_cpp_with_provenance_repo/minifi.properties
##########
@@ -0,0 +1,32 @@
+nifi.version=0.6.0
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties
Posted by GitBox <gi...@apache.org>.
adam-markovics commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r824444592
##########
File path: docker/test/integration/minifi/core/ImageStore.py
##########
@@ -111,6 +113,22 @@ def __build_simple_minifi_cpp_image_with_root(self):
return self.__build_image(dockerfile)
+ def __build_minifi_cpp_image_with_provenance_repo(self):
+ dockerfile = dedent("""FROM {base_image}
+ USER root
Review comment:
Done, also the other similar ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties
Posted by GitBox <gi...@apache.org>.
lordgamez closed pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r823603532
##########
File path: extensions/rocksdb-repos/ProvenanceRepository.h
##########
@@ -72,7 +72,7 @@ class ProvenanceRepository : public core::Repository, public std::enable_shared_
if (running_)
return;
running_ = true;
- thread_ = std::thread(&ProvenanceRepository::run, shared_from_this());
+ thread_ = std::thread(&ProvenanceRepository::run, this);
Review comment:
I think the mac failure comes from the main branch. Something caused that test to fail about half the time on mac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r823970101
##########
File path: docker/test/integration/resources/minifi_cpp_with_provenance_repo/minifi.properties
##########
@@ -0,0 +1,32 @@
+nifi.version=0.6.0
Review comment:
also not important at all, but the version should be `0.12.0`
##########
File path: docker/test/integration/minifi/core/ImageStore.py
##########
@@ -111,6 +113,22 @@ def __build_simple_minifi_cpp_image_with_root(self):
return self.__build_image(dockerfile)
+ def __build_minifi_cpp_image_with_provenance_repo(self):
+ dockerfile = dedent("""FROM {base_image}
+ USER root
Review comment:
very minor, but this will create a string like this:
```
FROM {base_image}
USER root
etc
```
in order to get
```
FROM {base_image}
USER root
etc
```
you need to write
```suggestion
dockerfile = dedent("""\
FROM {base_image}
USER root
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r823541337
##########
File path: extensions/rocksdb-repos/ProvenanceRepository.h
##########
@@ -72,7 +72,7 @@ class ProvenanceRepository : public core::Repository, public std::enable_shared_
if (running_)
return;
running_ = true;
- thread_ = std::thread(&ProvenanceRepository::run, shared_from_this());
+ thread_ = std::thread(&ProvenanceRepository::run, this);
Review comment:
I don't think it's urgent. I'll wait for the tests before approving, then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r822914457
##########
File path: extensions/rocksdb-repos/ProvenanceRepository.h
##########
@@ -72,7 +72,7 @@ class ProvenanceRepository : public core::Repository, public std::enable_shared_
if (running_)
return;
running_ = true;
- thread_ = std::thread(&ProvenanceRepository::run, shared_from_this());
Review comment:
I can confirm that this fixes the ProvenanceRepository crash. Are the tests going to be in this pull request, or in a separate one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org