You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/22 14:17:17 UTC

[GitHub] [yunikorn-core] craigcondit commented on a diff in pull request #434: [YUNIKORN-1288] check for pseudo version

craigcondit commented on code in PR #434:
URL: https://github.com/apache/yunikorn-core/pull/434#discussion_r951497336


##########
Makefile:
##########
@@ -110,7 +110,6 @@ check_scripts: install_shellcheck
 # from the Makefile. That caused the pull-request license check run from the github action to
 # always pass. The syntax for find is slightly different too but that at least works in a similar
 # way on both Mac and Linux. Excluding all .git* files from the checks.
-OS := $(shell uname -s | tr '[:upper:]' '[:lower:]')

Review Comment:
   Is this intended?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org