[jira] [Comment Edited] (OFBIZ-12279) Macro renderLink default height and width not retrieved on menus

["Leila Mekika (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379030#comment-17379030 ] 

Leila Mekika edited comment on OFBIZ-12279 at 7/12/21, 8:06 AM:
----------------------------------------------------------------

Hello [~jleroux],

the implication is that when we open the layered modal, it is reduce to the minimum (title bar size) and we have to expand the modal window to see its content.

I think it can be considered like a bug :)

 


was (Author: mleila):
Hello [~jleroux],

the implication is that when we open the layered modal, it is reduce to the minimum and we have to expand the window to see its content.

I think it can be considered like a bug :)

 

> Macro renderLink default height and width not retrieved on menus
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-12279
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12279
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: Leila Mekika
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-12279.patch
>
>
> Menus link defaut parameters for height and width are not considered when the link is generated
> The problem seems to be that when parameter with empty value is passed to the macro,  macro default values are not retrieved.
> *To reproduce*
> you can create a "layered-modal" type link in a menu and click on the link (without height nor width):
> this will generate the link with parameters "data-dialog-height" and "data-dialog-width" empty
> *Patch provided*
> When applied, the MacroMenuRenderer.renderLink  will not send empty values to the macro so that default value will be retrieved (what is actually done on MacroFormRenderer.renderLookup)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)