You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/08/14 09:35:12 UTC

[GitHub] jthomas commented on issue #129: Iam enablement

jthomas commented on issue #129: Iam enablement
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/129#issuecomment-412813472
 
 
   This is a necessary change to the library to support IAM. The implementation looks good apart from the comments above. 👍
   
   However, this PR was opened with no description or background on the changes. Ideally it should be tied to an existing issue so the community can discuss the changes and debate any API changes. It is hard to merge PRs with no context and doesn't help others provide feedback before an implentation. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services