[jira] [Commented] (HIVE-7098) RecordUpdater should extend RecordWriter

["Alan Gates (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037817#comment-14037817 ] 

Alan Gates commented on HIVE-7098:
----------------------------------

Ran the failing tests locally, all of which pass except root_dir_external_table which fails on trunk as well.  So I conclude none of these are issues for this patch.

> RecordUpdater should extend RecordWriter
> ----------------------------------------
>
>                 Key: HIVE-7098
>                 URL: https://issues.apache.org/jira/browse/HIVE-7098
>             Project: Hive
>          Issue Type: Sub-task
>          Components: File Formats, Transactions
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: HIVE-7098.patch
>
>
> A new interface ql.io.RecordUpdater was added as part of the ACID work in 0.13.  This interface should extend RecordWriter because:
> # If it does not significant portions of FileSinkOperator will have to be reworked to handle both RecordWriter and RecordUpdater
> # Once a file format accepts transactions, it should not generally be possible to write using RecordWriter.write as that will write old style records without transaction information.



--
This message was sent by Atlassian JIRA
(v6.2#6252)