[jira] [Resolved] (KAFKA-7560) PushHttpMetricsReporter should not convert metric value to double

["Ewen Cheslack-Postava (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-7560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ewen Cheslack-Postava resolved KAFKA-7560.
------------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.1.0
                   2.2.0

Issue resolved by pull request 5886
[https://github.com/apache/kafka/pull/5886]

> PushHttpMetricsReporter should not convert metric value to double
> -----------------------------------------------------------------
>
>                 Key: KAFKA-7560
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7560
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 2.1.0
>            Reporter: Stanislav Kozlovski
>            Assignee: Dong Lin
>            Priority: Blocker
>             Fix For: 2.2.0, 2.1.0
>
>
> Currently PushHttpMetricsReporter will convert value from KafkaMetric.metricValue() to double. This will not work for non-numerical metrics such as version in AppInfoParser whose value can be string. This has caused issue for PushHttpMetricsReporter which in turn caused system test kafkatest.tests.client.quota_test.QuotaTest.test_quota to fail with the following exception:  
> {code:java}
>  File "/opt/kafka-dev/tests/kafkatest/tests/client/quota_test.py", line 196, in validate     metric.value for k, metrics in producer.metrics(group='producer-metrics', name='outgoing-byte-rate', client_id=producer.client_id) for metric in metrics ValueError: max() arg is an empty sequence
> {code}
> Since we allow metric value to be object, PushHttpMetricsReporter should also read metric value as object and pass it to the http server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)