You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2018/08/01 02:52:42 UTC
Review Request 68139: HIVE-14493
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68139/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-14493
https://issues.apache.org/jira/browse/HIVE-14493
Repository: hive-git
Description
-------
HIVE-14493
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 61396e76abc8ccb8c4a41f1b9f498736c114eb0b
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 49f5487f400a9278248d5ab279dcc9c6a551c416
ql/src/test/queries/clientpositive/materialized_view_partitioned.q PRE-CREATION
ql/src/test/results/clientpositive/llap/materialized_view_partitioned.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/68139/diff/1/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 68139: HIVE-14493
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
> On Aug. 1, 2018, 4:32 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
> > Line 1951 (original), 1965 (patched)
> > <https://reviews.apache.org/r/68139/diff/2/?file=2065704#file2065704line1965>
> >
> > Can we reuse viewPartition rule for this. Only diff is ON vs BY keyword. I think its better to be consistent with views (which uses ON) then tables (BY) in this case.
LGTM, fixed.
> On Aug. 1, 2018, 4:32 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/materialized_view_partitioned.q
> > Lines 56 (patched)
> > <https://reviews.apache.org/r/68139/diff/2/?file=2065705#file2065705line56>
> >
> > I see there are no select from src_txn in tests. I thought rewriting will work on partitioned MVs without any changes. Selecting MV among multiple views needs some work.
Yes, rewriting is working, I had just included it in follow-up patch, but I think it makes sense to include it in this one indeed. I have added tests.
On top of that I incorporated a small change that I had made in the registry to be able to basically change the _dummy_ value config once it has been initialized.
- Jesús
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68139/#review206721
-----------------------------------------------------------
On Aug. 1, 2018, 3:07 a.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68139/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 3:07 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-14493
> https://issues.apache.org/jira/browse/HIVE-14493
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14493
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 61396e76abc8ccb8c4a41f1b9f498736c114eb0b
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 49f5487f400a9278248d5ab279dcc9c6a551c416
> ql/src/test/queries/clientpositive/materialized_view_partitioned.q PRE-CREATION
> ql/src/test/results/clientpositive/llap/materialized_view_partitioned.q.out PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68139/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 68139: HIVE-14493
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68139/#review206721
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
Line 1951 (original), 1965 (patched)
<https://reviews.apache.org/r/68139/#comment289805>
Can we reuse viewPartition rule for this. Only diff is ON vs BY keyword. I think its better to be consistent with views (which uses ON) then tables (BY) in this case.
ql/src/test/queries/clientpositive/materialized_view_partitioned.q
Lines 56 (patched)
<https://reviews.apache.org/r/68139/#comment289806>
I see there are no select from src_txn in tests. I thought rewriting will work on partitioned MVs without any changes. Selecting MV among multiple views needs some work.
- Ashutosh Chauhan
On Aug. 1, 2018, 3:07 a.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68139/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 3:07 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-14493
> https://issues.apache.org/jira/browse/HIVE-14493
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14493
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 61396e76abc8ccb8c4a41f1b9f498736c114eb0b
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 49f5487f400a9278248d5ab279dcc9c6a551c416
> ql/src/test/queries/clientpositive/materialized_view_partitioned.q PRE-CREATION
> ql/src/test/results/clientpositive/llap/materialized_view_partitioned.q.out PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68139/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 68139: HIVE-14493
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68139/
-----------------------------------------------------------
(Updated Aug. 1, 2018, 5:37 p.m.)
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-14493
https://issues.apache.org/jira/browse/HIVE-14493
Repository: hive-git
Description
-------
HIVE-14493
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 4d2eacb498833cb9942105c9576da1c9f5598419
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 5c9162f1e162596105468c959acb365691b24203
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 943227fb198c63fd52298605ff60bd5ffaccc645
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 61396e76abc8ccb8c4a41f1b9f498736c114eb0b
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 49f5487f400a9278248d5ab279dcc9c6a551c416
ql/src/test/queries/clientpositive/materialized_view_partitioned.q PRE-CREATION
ql/src/test/queries/clientpositive/materialized_view_rewrite_part_1.q PRE-CREATION
ql/src/test/queries/clientpositive/materialized_view_rewrite_part_2.q PRE-CREATION
ql/src/test/results/clientpositive/llap/materialized_view_partitioned.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/materialized_view_rewrite_part_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/materialized_view_rewrite_part_2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/68139/diff/3/
Changes: https://reviews.apache.org/r/68139/diff/2-3/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 68139: HIVE-14493
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68139/
-----------------------------------------------------------
(Updated Aug. 1, 2018, 3:07 a.m.)
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-14493
https://issues.apache.org/jira/browse/HIVE-14493
Repository: hive-git
Description
-------
HIVE-14493
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 61396e76abc8ccb8c4a41f1b9f498736c114eb0b
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 49f5487f400a9278248d5ab279dcc9c6a551c416
ql/src/test/queries/clientpositive/materialized_view_partitioned.q PRE-CREATION
ql/src/test/results/clientpositive/llap/materialized_view_partitioned.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/68139/diff/2/
Changes: https://reviews.apache.org/r/68139/diff/1-2/
Testing
-------
Thanks,
Jesús Camacho Rodríguez