You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/10/14 05:03:58 UTC

[GitHub] [pulsar] jiazhai commented on a change in pull request #5148: Validate topic name before creating partition/non partition topic via admin cli.

jiazhai commented on a change in pull request #5148: Validate topic name before creating partition/non partition topic via admin cli.
URL: https://github.com/apache/pulsar/pull/5148#discussion_r334327020
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TopicsConsumerImplTest.java
 ##########
 @@ -685,92 +685,6 @@ public void testMultiTopicsMessageListener() throws Exception {
         consumer.close();
     }
 
-
-    /**
-     * Test topic partitions auto subscribed.
-     *
-     * Steps:
-     * 1. Create a consumer with 2 topics, and each topic has 2 partitions: xx-partition-0, xx-partition-1.
-     * 2. produce message to xx-partition-2, and verify consumer could not receive message.
 
 Review comment:
   How about just remove this step-2 instead of the whole test case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services