You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/17 10:10:51 UTC

[GitHub] [skywalking-rocketbot-ui] horber opened a new pull request #473: Support double click to close rk sidebox

horber opened a new pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 edited a comment on pull request #473: Support double click to close rk sidebox

Posted by GitBox <gi...@apache.org>.
Fine0830 edited a comment on pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473#issuecomment-821938700


   I don't think we need this. Close side boxes by the `x` or the backdrop. Double click is easy to cause mis-operation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #473: Support double click to close rk sidebox

Posted by GitBox <gi...@apache.org>.
horber commented on pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473#issuecomment-824536407


   ![image](https://user-images.githubusercontent.com/5698982/115657347-489bdd80-a369-11eb-8780-8aca73457314.png)
   Could we adjust it so that there is 10% space on the right side to close the shell layer, and the operation efficiency will be much higher @Fine0830 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #473: Adjust the width of 'rk-sidebox' under traceDetail component

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473#issuecomment-1053202766


   Rocketbot UI is replaced by the new [Booster UI](https://github.com/apache/skywalking-booster-ui) since 9.0.0 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #473: Support double click to close rk sidebox

Posted by GitBox <gi...@apache.org>.
horber commented on pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473#issuecomment-822207857


   where is the backdrop，I feel that except for X, clicking anywhere has no effect. However, the current area of X is very small, and the user experience is not very good


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #473: Support double click to close rk sidebox

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473#issuecomment-822208816


   I think she means all these space, 
   ![image](https://user-images.githubusercontent.com/5441976/115191580-35e09900-a11c-11eb-99aa-9b124c5aa2b5.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #473: Support double click to close rk sidebox

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473#issuecomment-821938700


   I don't think we need this. Close side boxes by the `x` and the backdrop. Double click is easy to cause mis-operation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng closed pull request #473: Adjust the width of 'rk-sidebox' under traceDetail component

Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #473: Support double click to close rk sidebox

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473#issuecomment-822243650


   If you like, you can add a button to close a side box.
   ![test](https://user-images.githubusercontent.com/20871783/115198476-ac819480-a124-11eb-8688-959f7ebfe4f0.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #473: Support double click to close rk sidebox

Posted by GitBox <gi...@apache.org>.
horber commented on pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473#issuecomment-822209272


   I prefer to use shortcut keys, such as ESC, but there are problems with binding Keyup events. Do you have any better way to improve the user experience @Fine0830 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #473: Support double click to close rk sidebox

Posted by GitBox <gi...@apache.org>.
horber commented on pull request #473:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/473#issuecomment-822211461


   ![image](https://user-images.githubusercontent.com/5698982/115192012-d2a33680-a11c-11eb-87f7-beaf8f1c2105.png)
   In fact,  The page looks like this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org