[GitHub] [ozone] sadanand48 commented on pull request #2701: HDDS-5674.[Ozone-Streaming] Handle client retries on exception

[GitBox <gi...@apache.org>]

sadanand48 commented on pull request #2701:
URL: https://github.com/apache/ozone/pull/2701#issuecomment-940070714


   Thanks @szetszwo and @bshashikant  for the review.  Yes I will be adding more tests. Also , we are not using `BufferPool` 
    here instead maintaining a list that contains a reference to the buffers that are passed by the client.  Currently we maintain a `commitIndexMap` which contains list of buffers for a particular commitIndex and the buffers are discarded from the list during stream watchForCommit.
   
   Currently on retry , we discard the previous buffers in the bufferList and  start from 0 regardless of whether all the nodes have upto certain data. In a follow up task , I  will maintain stream ack like you suggested and only retry  writing the data that is not present in all nodes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org