You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/05 16:20:16 UTC

[GitHub] [cloudstack] shwstppr opened a new pull request #5285: ui: fix handle action response

shwstppr opened a new pull request #5285:
URL: https://github.com/apache/cloudstack/pull/5285


   ### Description
   
   Fixes #5284
   Fix for handling action API response
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5285: ui: fix handle action response

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5285:
URL: https://github.com/apache/cloudstack/pull/5285#issuecomment-893589845


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5285: ui: fix handle action API response

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5285:
URL: https://github.com/apache/cloudstack/pull/5285#issuecomment-894226339


   @shwstppr should we check 4.15 for this or is the origin known to be newer?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5285: ui: fix handle action API response

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5285:
URL: https://github.com/apache/cloudstack/pull/5285#issuecomment-894259400


   @DaanHoogland issue is not there in 4.15. It crept in with https://github.com/apache/cloudstack/commit/66e7bdedac76fb2c3f8d87e537e482c73af4799a which was trying to fix ui build failure after 4.15 forward merge into main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5285: ui: fix handle action API response

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5285:
URL: https://github.com/apache/cloudstack/pull/5285#issuecomment-894295173


   LGTM manually tested - merged based on approvals


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5285: ui: fix handle action response

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5285:
URL: https://github.com/apache/cloudstack/pull/5285#issuecomment-893593682


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5285 (SL-JID-481)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez merged pull request #5285: ui: fix handle action API response

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5285:
URL: https://github.com/apache/cloudstack/pull/5285


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5285: ui: fix handle action response

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5285:
URL: https://github.com/apache/cloudstack/pull/5285#issuecomment-893590409


   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org