You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by ramaraochavali <gi...@git.apache.org> on 2018/08/19 06:28:13 UTC
[GitHub] curator pull request #277: add support for configuring Zk Watches
GitHub user ramaraochavali opened a pull request:
https://github.com/apache/curator/pull/277
add support for configuring Zk Watches
In our use case, we use `TreeCache` to get Zk Data periodically. We start `TreeCache` read data and close it. In this use case, The `ZkWatchManager` of `ZooKeeper` class keeps growing for every TreeCache operation because new `TreeNode` objects are created and added there leading to a memory leak. Also since we do not want the Watcher to periodically watch, this creates unnecessary background operations.
In this PR, Made the createZkWatches configurable in the Builder, so that use cases like ours can set it to false. The default is true, retaining the current behaviour.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramaraochavali/curator feature/configurable_zk_watchers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #277
----
commit d641837ff98e14e1b6d8e0d824690be5244aaf51
Author: Rama <ra...@...>
Date: 2018-08-19T06:22:45Z
add support for no watches
----
---
[GitHub] curator issue #277: add support for configuring Zk Watches
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/curator/pull/277
Please open a Jira issue for this. See here - https://cwiki.apache.org/confluence/display/CURATOR/Submitting+Pull+Requests - then maybe @dragonsinth can take a look at this.
---
[GitHub] curator pull request #277: [CURATOR-477] add support for configuring Zk Watc...
Posted by ramaraochavali <gi...@git.apache.org>.
Github user ramaraochavali closed the pull request at:
https://github.com/apache/curator/pull/277
---
[GitHub] curator issue #277: [CURATOR-477] add support for configuring Zk Watches
Posted by ramaraochavali <gi...@git.apache.org>.
Github user ramaraochavali commented on the issue:
https://github.com/apache/curator/pull/277
@Randgalt Created JIRA issue https://issues.apache.org/jira/browse/CURATOR-477. Please let me know if any thing else needs to be done. Please review and let me know if any changes are required.
---
[GitHub] curator issue #277: add support for configuring Zk Watches
Posted by dragonsinth <gi...@git.apache.org>.
Github user dragonsinth commented on the issue:
https://github.com/apache/curator/pull/277
@Randgalt the use case makes sense, but there's actually no TreeCache changes in this PR, it's all Framework stuff.
---
[GitHub] curator issue #277: [CURATOR-477] add support for configuring Zk Watches
Posted by ramaraochavali <gi...@git.apache.org>.
Github user ramaraochavali commented on the issue:
https://github.com/apache/curator/pull/277
@Randgalt @dragonsinth on a second thought, I think just cleaner to it at the `TreeCache` level. So closing this PR and opening a fresh PR for it with correct branch name as well. The correct PR is https://github.com/apache/curator/pull/278
---