You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/06 02:09:02 UTC
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request
#4625: Fix invalid error information in unit test of sharding-scaling module
KomachiSion opened a new pull request #4625: Fix invalid error information in unit test of sharding-scaling module
URL: https://github.com/apache/incubator-shardingsphere/pull/4625
Fixes #4616 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4625: Fix invalid error information in unit test of sharding-scaling module
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4625: Fix invalid error information in unit test of sharding-scaling module
URL: https://github.com/apache/incubator-shardingsphere/pull/4625#issuecomment-595568185
## Pull Request Test Coverage Report for [Build 10063](https://coveralls.io/builds/29168644)
* **1** of **1** **(100.0%)** changed or added relevant line in **1** file are covered.
* **22** unchanged lines in **7** files lost coverage.
* Overall coverage decreased (**-0.04%**) to **59.052%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/EventType.java](https://coveralls.io/builds/29168644/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2FEventType.java#L23) | 2 | 0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/AbstractSyncExecutor.java](https://coveralls.io/builds/29168644/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2FAbstractSyncExecutor.java#L46) | 2 | 60.0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29168644/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L84) | 2 | 51.85% |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29168644/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/engine/SyncTaskExecuteCallback.java](https://coveralls.io/builds/29168644/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fengine%2FSyncTaskExecuteCallback.java#L48) | 3 | 14.29% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/engine/DefaultSyncTaskExecuteEngine.java](https://coveralls.io/builds/29168644/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fengine%2FDefaultSyncTaskExecuteEngine.java#L66) | 4 | 78.79% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/SyncExecutorGroup.java](https://coveralls.io/builds/29168644/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2FSyncExecutorGroup.java#L76) | 6 | 15.38% |
<!-- | **Total:** | **22** | | -->
| Totals | [](https://coveralls.io/builds/29168644) |
| :-- | --: |
| Change from base [Build 999](https://coveralls.io/builds/29167969): | -0.04% |
| Covered Lines: | 12101 |
| Relevant Lines: | 20492 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #4625: Fix
invalid error information in unit test of sharding-scaling module
Posted by GitBox <gi...@apache.org>.
dongzl merged pull request #4625: Fix invalid error information in unit test of sharding-scaling module
URL: https://github.com/apache/incubator-shardingsphere/pull/4625
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4625: Fix
invalid error information in unit test of sharding-scaling module
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4625: Fix invalid error information in unit test of sharding-scaling module
URL: https://github.com/apache/incubator-shardingsphere/pull/4625#issuecomment-595568185
## Pull Request Test Coverage Report for [Build 1998](https://coveralls.io/builds/29168524)
* **1** of **1** **(100.0%)** changed or added relevant line in **1** file are covered.
* **19** unchanged lines in **6** files lost coverage.
* Overall coverage increased (+**0.04%**) to **59.135%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/EventType.java](https://coveralls.io/builds/29168524/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2FEventType.java#L23) | 2 | 0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/AbstractSyncExecutor.java](https://coveralls.io/builds/29168524/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2FAbstractSyncExecutor.java#L46) | 2 | 60.0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29168524/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L84) | 2 | 81.48% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/engine/SyncTaskExecuteCallback.java](https://coveralls.io/builds/29168524/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fengine%2FSyncTaskExecuteCallback.java#L48) | 3 | 14.29% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/engine/DefaultSyncTaskExecuteEngine.java](https://coveralls.io/builds/29168524/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fengine%2FDefaultSyncTaskExecuteEngine.java#L66) | 4 | 78.79% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/SyncExecutorGroup.java](https://coveralls.io/builds/29168524/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2FSyncExecutorGroup.java#L76) | 6 | 15.38% |
<!-- | **Total:** | **19** | | -->
| Totals | [](https://coveralls.io/builds/29168524) |
| :-- | --: |
| Change from base [Build 999](https://coveralls.io/builds/29167969): | 0.04% |
| Covered Lines: | 12118 |
| Relevant Lines: | 20492 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services