[GitHub] [cassandra] bereng commented on pull request #1891: Cassandra 14227 trunk

["bereng (via GitHub)" <gi...@apache.org>]

bereng commented on PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#issuecomment-1514364495

   @adelapena I just committed:
   - [fce297e](https://github.com/apache/cassandra/pull/1891/commits/fce297e17d5c7ad337912dad6bc6964c4b300b4f) to add the right 5.0 version
   - [575f809](https://github.com/apache/cassandra/pull/1891/commits/575f809b57dde4c19ca682b0f06315a38d11f6c5) makes the code behave in 'compatibility mode': nc, MV 4.0, etc It [passes](https://app.circleci.com/pipelines/github/bereng/cassandra/913/workflows/8ec1fa9a-1c45-436a-8c22-2f20675fce5f) all tests. The only 2 dtest failures are bc on dtests we can't detect when we run in one mode or the other, sthg CASSANDRA-18301 should address. The tests would pass if that condition was detected. I also copied the a data folder into a 4.1 install and it works where the only errors were related to other tickets that again CASSANDRA-18301 should address
   - [45aec2c](https://github.com/apache/cassandra/pull/1891/commits/45aec2cc5be195643b90ab61b95316ffdd19fda3) Switches the code back to a 5.0 config and all tests [pass](https://app.circleci.com/pipelines/github/bereng/cassandra/914/workflows/a2e9babe-8231-4ef9-9785-fc72ab887c31)
   
   CASSANDRA-18301 should only toggle those versions and the codebase now behaves with the old or new behavior accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org