You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/18 10:28:49 UTC

[GitHub] [hive] dengzhhu653 commented on a change in pull request #1780: HIVE-24534: Prevent comparisons between characters and decimals types when strict checks enabled

dengzhhu653 commented on a change in pull request #1780:
URL: https://github.com/apache/hive/pull/1780#discussion_r559458095



##########
File path: ql/src/test/results/clientpositive/llap/avrotblsjoin.q.out
##########
@@ -71,9 +71,9 @@ POSTHOOK: Input: _dummy_database@_dummy_table
 POSTHOOK: Output: default@table1_1
 POSTHOOK: Lineage: table1_1.col1 SCRIPT []
 POSTHOOK: Lineage: table1_1.col2 SCRIPT []
-WARNING: Comparing a bigint and a string may result in a loss of precision.
-WARNING: Comparing a bigint and a string may result in a loss of precision.
-WARNING: Comparing a bigint and a string may result in a loss of precision.
+WARNING: Comparing string and bigint may result in loss of information.

Review comment:
       Maybe `a loss of precision` is more user friendly compared to `information`.

##########
File path: ql/src/test/results/clientpositive/llap/partition_wise_fileformat2.q.out
##########
@@ -123,31 +123,6 @@ POSTHOOK: Input: default@partition_test_partitioned@dt=102
 		100
 		100
 		100
-238	val_238	102

Review comment:
       the result of this qfile seems unrelated to the changes...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org