You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/17 20:10:02 UTC
[GitHub] [arrow] westonpace opened a new pull request #9518: std::atomic had been left uninitialized
westonpace opened a new pull request #9518:
URL: https://github.com/apache/arrow/pull/9518
The UBSAN test was periodically failing because an uninitialized std::atomic<bool> could have any value. I did a review of std::atomic<bool> and found at least one other place where I had made this incorrect assumption. Both are fixed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9518: std::atomic had been left uninitialized
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9518:
URL: https://github.com/apache/arrow/pull/9518#issuecomment-780822243
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9518: ARROW-11668: [C++] Sporadic UBSAN error in FutureStessTest.TryAddCallback
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9518:
URL: https://github.com/apache/arrow/pull/9518#issuecomment-781231871
I've restarted the failing check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9518: ARROW-11668: [C++] Sporadic UBSAN error in FutureStessTest.TryAddCallback
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9518:
URL: https://github.com/apache/arrow/pull/9518#issuecomment-780822760
https://issues.apache.org/jira/browse/ARROW-11668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace edited a comment on pull request #9518: ARROW-11668: [C++] Sporadic UBSAN error in FutureStessTest.TryAddCallback
Posted by GitBox <gi...@apache.org>.
westonpace edited a comment on pull request #9518:
URL: https://github.com/apache/arrow/pull/9518#issuecomment-781037442
@pitrou Please review. 1 failing check seems unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #9518: ARROW-11668: [C++] Sporadic UBSAN error in FutureStessTest.TryAddCallback
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9518:
URL: https://github.com/apache/arrow/pull/9518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #9518: ARROW-11668: [C++] Sporadic UBSAN error in FutureStessTest.TryAddCallback
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #9518:
URL: https://github.com/apache/arrow/pull/9518#issuecomment-781037442
@pitrou Please review. 1 failing test seems unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org