You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2023/01/18 13:31:03 UTC

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

adamsaghy commented on code in PR #2897:
URL: https://github.com/apache/fineract/pull/2897#discussion_r1073538291


##########
fineract-avro-schemas/src/main/avro/loan/v1/LoanAccountStayedLockedDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+    "name": "LoanAccountStayedLockedDataV1",
+    "namespace": "org.apache.fineract.avro.loan.v1",
+    "type": "record",
+    "fields": [
+        {
+            "default": null,

Review Comment:
   if the loan id cannot be null, please reflect it in the avro schema as well!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org