You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2025/07/26 20:37:00 UTC
[PR] [CI] pre-commit add hook `check-zip-file-is-not-committed` [sedona]
jbampton opened a new pull request, #2172:
URL: https://github.com/apache/sedona/pull/2172
Zip files should not be allowed in the repository as they are hard to track and have security implications
## Did you read the Contributor Guide?
- Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
## Is this PR related to a ticket?
- No this is a CI update. The PR name follows the format `[CI] my subject`
## What changes were proposed in this PR?
Added another hook to our pre-commit framework.
## How was this patch tested?
Tested by adding a ZIP file locally and then ran `pre-commit run --all-files` and this hook failed.
When there are no ZIP files the hook passes.
## Did this PR include necessary documentation updates?
- No, this PR does not affect any public API so no need to change the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] pre-commit add hook `check-zip-file-is-not-committed` [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #2172:
URL: https://github.com/apache/sedona/pull/2172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] pre-commit add hook `check-zip-file-is-not-committed` [sedona]
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on code in PR #2172:
URL: https://github.com/apache/sedona/pull/2172#discussion_r2233271031
##########
.pre-commit-config.yaml:
##########
@@ -40,6 +40,14 @@ repos:
files: \.(js|ya?ml)$
language: node
additional_dependencies: ['prettier@3.6.2']
+ - id: check-zip-file-is-not-committed
+ name: check no zip files are committed
+ description: Zip files are not allowed in the repository
+ language: fail
+ entry: |
+ Zip files are not allowed in the repository as they are hard to
+ track and have security implications. Please remove the zip file from the repository.
+ files: \.zip$
Review Comment:
```suggestion
files: (?i)\.zip$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org