You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "haohao0103 (via GitHub)" <gi...@apache.org> on 2023/03/07 10:03:26 UTC

[GitHub] [hbase] haohao0103 commented on a diff in pull request #5082: HBASE-27688 HFile splitting occurs during bulkload, the CREATE_TIME_TS of hfileinfo is 0

haohao0103 commented on code in PR #5082:
URL: https://github.com/apache/hbase/pull/5082#discussion_r1127625101


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestBulkLoadHFiles.java:
##########
@@ -623,6 +643,17 @@ private int verifyHFile(Path p) throws IOException {
     return count;
   }
 
+  private void verifyHFileCreateTimeTS(Path p) throws IOException {
+    Configuration conf = util.getConfiguration();
+    HFile.Reader reader =
+      HFile.createReader(p.getFileSystem(conf), p, new CacheConfig(conf), true, conf);
+    final HFileInfo hFileInfo = reader.getHFileInfo();
+    final long fileCreateTime = hFileInfo.getHFileContext().getFileCreateTime();
+    reader.close();
+    assertTrue(fileCreateTime != 0);

Review Comment:
   thanks,I have modified it according to your suggestions. Please tell me if there are any shortcomings



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org