[jira] Commented: (JCR-680) Improve the Value implementation

["Stefan Guggisberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461995 ] 

Stefan Guggisberg commented on JCR-680:
---------------------------------------

> This patch fixes JCR-320 and notably simplifies the Value classes.

it might be just my lack of understanding but the proposed redesign 
is IMO more complex and harder to grasp than gthe current implementation.

i am not against redesigning the Value implementations in general but
i frankly fail to see the net benefit of the proposed redesign. it's harder
to understand (at least for me ;) 

btw: the patch is still quite big and quite difficult to read.

> Improve the Value implementation
> --------------------------------
>
>                 Key: JCR-680
>                 URL: https://issues.apache.org/jira/browse/JCR-680
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>         Attachments: class.jpg, GenericValue.patch, JCR-680.patch
>
>
> The current Value implementation found in jackrabbit-jcr-commons has some deficiencies like Value.equals() being incorrect in some cases (see for example JCR-320), and Name and Path values not following namespace remappings.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira