You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2020/01/13 17:17:48 UTC

[Impala-ASF-CR] WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct 

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15021


Change subject: WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................

WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct

The root type should be struct as far as I know, and this was
checked with a DCHECK, leading to crashes in fuzz tests. This
change replaced the DCHECK with returning an error message.

Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Testing:
TODO: no test yet, as I couldn't reproduce the crash until now
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/orc-metadata-utils.cc
M be/src/exec/orc-metadata-utils.h
3 files changed, 19 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/15021/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5428/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 14:50:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15021/2/be/src/exec/orc-metadata-utils.cc
File be/src/exec/orc-metadata-utils.cc:

http://gerrit.cloudera.org:8080/#/c/15021/2/be/src/exec/orc-metadata-utils.cc@28
PS2, Line 28: type
> nit: type?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 14:22:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15021/3/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/15021/3/tests/query_test/test_scanners.py@1351
PS3, Line 1351: d
flake8: E303 too many blank lines (2)



-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 14:19:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5414/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Jan 2020 17:47:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................

IMPALA-9249: Fix ORC scanner crash when root type is not struct

The root type should be struct as far as I know, and this was
checked with a DCHECK, leading to crashes in fuzz tests. This
change replaced the DCHECK with returning an error message.

Testing:
- added corrupt ORC file and e2e test

Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Reviewed-on: http://gerrit.cloudera.org:8080/15021
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/orc-metadata-utils.cc
M be/src/exec/orc-metadata-utils.h
M testdata/data/README
A testdata/data/corrupt_root_type.orc
M tests/query_test/test_scanners.py
6 files changed, 40 insertions(+), 24 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5427/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 14:49:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 14:42:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Looks good to me. Let's ship this quick fix!

http://gerrit.cloudera.org:8080/#/c/15021/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15021/2//COMMIT_MSG@14
PS2, Line 14: TODO: no test yet, as I couldn't reproduce the crash until now
Sorry for not uploading a corrupt file in the JIRA. But I think we can skip test since it's trivial. Can also avoid adding a new file into our already large code base.


http://gerrit.cloudera.org:8080/#/c/15021/2/be/src/exec/orc-metadata-utils.cc
File be/src/exec/orc-metadata-utils.cc:

http://gerrit.cloudera.org:8080/#/c/15021/2/be/src/exec/orc-metadata-utils.cc@28
PS2, Line 28: node
nit: type?



-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 13:59:05 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15021

to look at the new patch set (#3).

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................

IMPALA-9249: Fix ORC scanner crash when root type is not struct

The root type should be struct as far as I know, and this was
checked with a DCHECK, leading to crashes in fuzz tests. This
change replaced the DCHECK with returning an error message.

Testing:
- added corrupt ORC file and e2e test

Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/orc-metadata-utils.cc
M be/src/exec/orc-metadata-utils.h
M testdata/data/README
A testdata/data/corrupt_root_type.orc
M tests/query_test/test_scanners.py
6 files changed, 43 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/15021/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 19:15:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15021

to look at the new patch set (#4).

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................

IMPALA-9249: Fix ORC scanner crash when root type is not struct

The root type should be struct as far as I know, and this was
checked with a DCHECK, leading to crashes in fuzz tests. This
change replaced the DCHECK with returning an error message.

Testing:
- added corrupt ORC file and e2e test

Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/orc-metadata-utils.cc
M be/src/exec/orc-metadata-utils.h
M testdata/data/README
A testdata/data/corrupt_root_type.orc
M tests/query_test/test_scanners.py
6 files changed, 40 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/15021/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15021

to look at the new patch set (#5).

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................

IMPALA-9249: Fix ORC scanner crash when root type is not struct

The root type should be struct as far as I know, and this was
checked with a DCHECK, leading to crashes in fuzz tests. This
change replaced the DCHECK with returning an error message.

Testing:
- added corrupt ORC file and e2e test

Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/orc-metadata-utils.cc
M be/src/exec/orc-metadata-utils.h
M testdata/data/README
A testdata/data/corrupt_root_type.orc
M tests/query_test/test_scanners.py
6 files changed, 40 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/15021/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 14:32:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5409/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 14:42:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15021

to look at the new patch set (#2).

Change subject: WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................

WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct

The root type should be struct as far as I know, and this was
checked with a DCHECK, leading to crashes in fuzz tests. This
change replaced the DCHECK with returning an error message.

Testing:
TODO: no test yet, as I couldn't reproduce the crash until now

Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/orc-metadata-utils.cc
M be/src/exec/orc-metadata-utils.h
3 files changed, 19 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/15021/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9249: Fix ORC scanner crash when root type is not struct

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )

Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5426/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 14:48:26 +0000
Gerrit-HasComments: No