You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "luwei16 (via GitHub)" <gi...@apache.org> on 2026/10/22 04:18:47 UTC
[PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
luwei16 opened a new pull request, #69426:
URL: https://github.com/apache/doris/pull/69426
### What problem does this PR solve?
Issue Number: None
Related PR: https://github.com/apache/doris/pull/61585
Problem Summary: Cloud ALTER TABLE property updates can leave cached tablet metadata stale on compute clusters until the next periodic refresh. A table changed from size_based to time_series compaction can therefore continue rejecting writes at the version limit. Backport the sync_tablet_meta RPC so FE notifies alive backends after a successful Meta Service update, and BE refreshes only tablets already cached locally. Keep notifications best effort and serialize metadata updates with rowset synchronization. Merge the target branch's existing cloud tablet manager and schema change tests, and use its visible-index overload in the partition mock.
### Release note
Cloud ALTER TABLE property changes proactively refresh cached tablet metadata across compute clusters, allowing new compaction settings to take effect sooner.
### Check List (For Author)
- Test: Unit Test and style checks
- ./run-fe-ut.sh --run 'CloudSchemaChangeHandlerTest,BackendServiceClientTest,BackendServiceProxyTest': 31 tests passed
- FE Core Checkstyle: zero violations
- build-support/clang-format.sh and build-support/check-format.sh passed with clang-format v16
- git diff --cached --check passed
- BE unit tests and live cloud regression were not run
- Behavior changed: Yes (notify backends to refresh cached tablet metadata after cloud ALTER TABLE property updates)
- Does this need documentation: No
(cherry picked from commit 75ddba65b40c07a518e8cf7926e20320110d7376)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6386687010
# FE Regression Coverage Report
Increment line coverage ` 53.45% (31/58)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6355115716
# BE Regression && UT Coverage Report
Increment line coverage `95.50% (106/111)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.39% (34515/45183) |
| Line Coverage | 61.23% (389904/636793) |
| Region Coverage | 58.14% (329048/565939) |
| Branch Coverage | 59.01% (151635/256947) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6387167102
# FE Regression Coverage Report
Increment line coverage ` 53.45% (31/58)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6386910825
# FE Regression Coverage Report
Increment line coverage ` 53.45% (31/58)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6332587207
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6386749453
# BE Regression && UT Coverage Report
Increment line coverage `95.50% (106/111)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.33% (34497/45195) |
| Line Coverage | 61.12% (389281/636958) |
| Region Coverage | 58.04% (328593/566164) |
| Branch Coverage | 58.90% (151394/257016) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6387643764
# BE Regression && UT Coverage Report
Increment line coverage `95.50% (106/111)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.33% (34496/45195) |
| Line Coverage | 61.13% (389342/636958) |
| Region Coverage | 58.07% (328760/566164) |
| Branch Coverage | 58.91% (151420/257016) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6387778542
# FE Regression Coverage Report
Increment line coverage ` 53.45% (31/58)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6391902938
skip buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #69426:
URL: https://github.com/apache/doris/pull/69426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6352994608
# FE Regression Coverage Report
Increment line coverage ` 53.45% (31/58)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6388499570
# BE Regression && UT Coverage Report
Increment line coverage `95.50% (106/111)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.37% (34514/45193) |
| Line Coverage | 61.16% (389572/636956) |
| Region Coverage | 58.11% (329005/566162) |
| Branch Coverage | 58.97% (151559/257016) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6386559508
# BE Regression && UT Coverage Report
Increment line coverage `95.50% (106/111)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.33% (34490/45186) |
| Line Coverage | 61.14% (389149/636504) |
| Region Coverage | 58.04% (328403/565807) |
| Branch Coverage | 58.93% (151348/256812) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6387031931
# BE Regression && UT Coverage Report
Increment line coverage `95.50% (106/111)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.33% (34497/45195) |
| Line Coverage | 61.12% (389297/636958) |
| Region Coverage | 58.04% (328610/566164) |
| Branch Coverage | 58.91% (151402/257016) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6338858172
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6384477915
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](cloud) Sync cached tablet metadata after alter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69426:
URL: https://github.com/apache/doris/pull/69426#issuecomment-6386161649
# FE UT Coverage Report
Increment line coverage ` 100.00% (58/58)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69426_a2cf29f26a25b97b1e0ba01a0cf7ccd4ac2430e1/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org