You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/18 13:19:17 UTC
[GitHub] [airflow] mik-laj opened a new pull request #13742: Dividing contributors guide into expert and beginner parts
mik-laj opened a new pull request #13742:
URL: https://github.com/apache/airflow/pull/13742
I have divided these documents into two parts because I have the impression that these documents have different audiences. Most new contributors do not need to be familiar with the internal processes of selecting a new PMC and committers. This is very important to us, but not important to newcomers who want to learn how the community works.
If anyone wants to learn more about it, I recommend two articles on this topic.
https://developers.google.com/tech-writing/one/audience
https://developers.google.com/tech-writing/one/documents
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13742:
URL: https://github.com/apache/airflow/pull/13742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559627480
##########
File path: CONTRIBUTING.rst
##########
@@ -23,6 +23,10 @@ Contributions
Contributions are welcome and are greatly appreciated! Every little bit helps,
and credit will always be given.
+This document aims to explain the subject of contributions if you have not contributed to
+any Open Source project, but it will also help people who have contributed to other projects learn about the
+rules of that community.
+
Review comment:
We should also add reference to the COMMITTERS.rst
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559720167
##########
File path: CONTRIBUTING.rst
##########
@@ -23,6 +23,10 @@ Contributions
Contributions are welcome and are greatly appreciated! Every little bit helps,
and credit will always be given.
+This document aims to explain the subject of contributions if you have not contributed to
+any Open Source project, but it will also help people who have contributed to other projects learn about the
+rules of that community.
+
Review comment:
AH. OK. I see it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559749110
##########
File path: COMMITTERS.rst
##########
@@ -0,0 +1,193 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+.. contents:: :local:
+
+Committers and PMS's
Review comment:
```suggestion
Committers and PMC's
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] paolaperaza commented on pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
paolaperaza commented on pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#issuecomment-762426859
Nice, @mik-laj ! @eladkal and I actually just met this morning about removing/cleaning up other content in Contributing.rst - splitting off everything under "Roles" into a different file/doc was one of the things we agreed on 😊
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559749619
##########
File path: COMMITTERS.rst
##########
@@ -0,0 +1,193 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+.. contents:: :local:
+
+Committers and PMS's
+====================
+
+This document assumes that you know how our community works in our community, but you would like to learn more about the rules by which we add new members.
+
+Before reading this document, you should be familiar with `Contributor guides <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__.
Review comment:
```suggestion
Before reading this document, you should be familiar with `Contributor's guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559625123
##########
File path: COMMITERS.rst
##########
@@ -0,0 +1,193 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
Review comment:
File name should be 'COMMITTERS.rst" (double T)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559637018
##########
File path: CONTRIBUTING.rst
##########
@@ -23,6 +23,10 @@ Contributions
Contributions are welcome and are greatly appreciated! Every little bit helps,
and credit will always be given.
+This document aims to explain the subject of contributions if you have not contributed to
+any Open Source project, but it will also help people who have contributed to other projects learn about the
+rules of that community.
+
Review comment:
Doe
##########
File path: CONTRIBUTING.rst
##########
@@ -23,6 +23,10 @@ Contributions
Contributions are welcome and are greatly appreciated! Every little bit helps,
and credit will always be given.
+This document aims to explain the subject of contributions if you have not contributed to
+any Open Source project, but it will also help people who have contributed to other projects learn about the
+rules of that community.
+
Review comment:
Done
##########
File path: COMMITERS.rst
##########
@@ -0,0 +1,193 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559749487
##########
File path: COMMITTERS.rst
##########
@@ -0,0 +1,193 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+.. contents:: :local:
+
+Committers and PMS's
+====================
+
+This document assumes that you know how our community works in our community, but you would like to learn more about the rules by which we add new members.
Review comment:
```suggestion
This document assumes that you know how Airflow's community work, but you would like to learn more about the rules by which we add new members.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559719580
##########
File path: CONTRIBUTING.rst
##########
@@ -23,6 +23,10 @@ Contributions
Contributions are welcome and are greatly appreciated! Every little bit helps,
and credit will always be given.
+This document aims to explain the subject of contributions if you have not contributed to
+any Open Source project, but it will also help people who have contributed to other projects learn about the
+rules of that community.
+
Review comment:
I added this in the section that uses the words PMC and Commiter for the first time.
https://github.com/apache/airflow/pull/13742/files#diff-76e7ca2f2843ac5f659b45382768c1b64bf8704e8d3c6189c4e3623f5d465bc2R103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559627480
##########
File path: CONTRIBUTING.rst
##########
@@ -23,6 +23,10 @@ Contributions
Contributions are welcome and are greatly appreciated! Every little bit helps,
and credit will always be given.
+This document aims to explain the subject of contributions if you have not contributed to
+any Open Source project, but it will also help people who have contributed to other projects learn about the
+rules of that community.
+
Review comment:
We should also ad reference to the COMMITTERS.rst
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559718151
##########
File path: CONTRIBUTING.rst
##########
@@ -23,6 +23,10 @@ Contributions
Contributions are welcome and are greatly appreciated! Every little bit helps,
and credit will always be given.
+This document aims to explain the subject of contributions if you have not contributed to
+any Open Source project, but it will also help people who have contributed to other projects learn about the
+rules of that community.
+
Review comment:
I cannot see it ? I thought about referring to "COMMITTERS.rst" from here. Just mention that information about how to be come committer/pmc is is available there. Otherwise no-one will even know that the file exists. CONTRIBUTING.rst is the "starting" point (it is linked to when PR is opened and even tooltip is displayed when it changed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#discussion_r559854592
##########
File path: CONTRIBUTING.rst
##########
@@ -96,9 +100,11 @@ Roles
There are several roles within the Airflow Open-Source community.
+For detailed information for each role, see: `Committers and PMS's <./COMMITTERS.rst>`__.
Review comment:
```suggestion
For detailed information for each role, see: `Committers and PMC's <./COMMITTERS.rst>`__.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13742: Dividing contributors guide into expert and beginner parts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13742:
URL: https://github.com/apache/airflow/pull/13742#issuecomment-762405311
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org