[jira] [Updated] (HADOOP-14060) KMS /logs servlet should have access control

["Yuanbo Liu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-14060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yuanbo Liu updated HADOOP-14060:
--------------------------------
    Attachment: HADOOP-14060-tmp.001.patch

Add a temp patch for your reference.
highlight that this patch is not a complete solution for this defect.
kms use web.xml to define filter chain for web path, it works for {{WebAppContext}}, but {{/logs}} doesn't use {{WebAppContext}} to define its filter chain. So there are two ways to fix this defect:
* Change the context of {{/logs}} in {{HttpServer2.java}}, just like my temp patch
* Use a filter initializer to setup global filter chain for all the web paths in {{HttpServer2.java}}

Since {{HttpServer2.java}} is used widely in different hadoop components, I'd prefer #2 to reduce compatibility issues. But #2 is a bit complex and need some time to generate a patch.

> KMS /logs servlet should have access control
> --------------------------------------------
>
>                 Key: HADOOP-14060
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14060
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: kms
>    Affects Versions: 3.0.0-alpha3
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>         Attachments: HADOOP-14060-tmp.001.patch
>
>
> HADOOP-14047 makes KMS call {{HttpServer2#setACL}}. Access control works fine for /conf, /jmx, /logLevel, and /stacks, but not for /logs.
> The code in {{AdminAuthorizedServlet#doGet}} for /logs and {{ConfServlet#doGet}} for /conf are quite similar. This makes me believe that /logs should subject to the same access control as intended by the original developer.
> IMHO this could either be my misconfiguration or there is a bug somewhere in {{HttpServer2}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org