You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2013/07/25 16:11:59 UTC

svn commit: r1506978 - in /subversion/branches/fsfs-improvements/subversion: libsvn_fs_fs/caching.c svnserve/svnserve.c

Author: stefan2
Date: Thu Jul 25 14:11:59 2013
New Revision: 1506978

URL: http://svn.apache.org/r1506978
Log:
On the fsfs-improvements branch: enable TxDelta caching by default

* subversion/libsvn_fs_fs/caching.c
  (read_config): default to TXDELTA caching option to "true"

* subversion/svnserve/svnserve.c
  (svnserve__options): update help string
  (main): update default value

Modified:
    subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs/caching.c
    subversion/branches/fsfs-improvements/subversion/svnserve/svnserve.c

Modified: subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs/caching.c
URL: http://svn.apache.org/viewvc/subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs/caching.c?rev=1506978&r1=1506977&r2=1506978&view=diff
==============================================================================
--- subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs/caching.c (original)
+++ subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs/caching.c Thu Jul 25 14:11:59 2013
@@ -116,7 +116,8 @@ read_config(svn_memcache_t **memcache_p,
   *cache_txdeltas
     = svn_hash__get_bool(fs->config,
                          SVN_FS_CONFIG_FSFS_CACHE_DELTAS,
-                         FALSE);
+                         TRUE);
+
   /* by default, cache fulltexts.
    * Most SVN tools care about reconstructed file content.
    * Thus, this is a reasonable default.

Modified: subversion/branches/fsfs-improvements/subversion/svnserve/svnserve.c
URL: http://svn.apache.org/viewvc/subversion/branches/fsfs-improvements/subversion/svnserve/svnserve.c?rev=1506978&r1=1506977&r2=1506978&view=diff
==============================================================================
--- subversion/branches/fsfs-improvements/subversion/svnserve/svnserve.c (original)
+++ subversion/branches/fsfs-improvements/subversion/svnserve/svnserve.c Thu Jul 25 14:11:59 2013
@@ -224,7 +224,7 @@ static const apr_getopt_option_t svnserv
         "                             "
         "revisions.\n"
         "                             "
-        "Default is no.\n"
+        "Default is yes.\n"
         "                             "
         "[used for FSFS repositories only]")},
     {"cache-fulltexts", SVNSERVE_OPT_CACHE_FULLTEXTS, 1,
@@ -547,7 +547,7 @@ int main(int argc, const char *argv[])
   params.username_case = CASE_ASIS;
   params.memory_cache_size = (apr_uint64_t)-1;
   params.cache_fulltexts = TRUE;
-  params.cache_txdeltas = FALSE;
+  params.cache_txdeltas = TRUE;
   params.cache_revprops = FALSE;
   params.zero_copy_limit = 0;
   params.error_check_interval = 4096;

Re: svn commit: r1506978 - in /subversion/branches/fsfs-improvements/subversion: libsvn_fs_fs/caching.c svnserve/svnserve.c

Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Sun, Aug 4, 2013 at 9:18 AM, Daniel Shahaf <da...@elego.de> wrote:

> Need to update mod_dav_svn.c:1176 as well
>

Fixed in r1510166 with a minor addition.
Thanks for the review!

-- Stefan^2.

Re: svn commit: r1506978 - in /subversion/branches/fsfs-improvements/subversion: libsvn_fs_fs/caching.c svnserve/svnserve.c

Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Sun, Aug 4, 2013 at 9:18 AM, Daniel Shahaf <da...@elego.de> wrote:

> Need to update mod_dav_svn.c:1176 as well
>

Fixed in r1510166 with a minor addition.
Thanks for the review!

-- Stefan^2.

Re: svn commit: r1506978 - in /subversion/branches/fsfs-improvements/subversion: libsvn_fs_fs/caching.c svnserve/svnserve.c

Posted by Daniel Shahaf <da...@elego.de>.
Need to update mod_dav_svn.c:1176 as well

stefan2@apache.org wrote on Thu, Jul 25, 2013 at 14:11:59 -0000:
> Author: stefan2
> Date: Thu Jul 25 14:11:59 2013
> New Revision: 1506978
> 
> URL: http://svn.apache.org/r1506978
> Log:
> On the fsfs-improvements branch: enable TxDelta caching by default
> 
> * subversion/libsvn_fs_fs/caching.c
>   (read_config): default to TXDELTA caching option to "true"
> 
> * subversion/svnserve/svnserve.c
>   (svnserve__options): update help string
>   (main): update default value

Re: svn commit: r1506978 - in /subversion/branches/fsfs-improvements/subversion: libsvn_fs_fs/caching.c svnserve/svnserve.c

Posted by Daniel Shahaf <da...@elego.de>.
Need to update mod_dav_svn.c:1176 as well

stefan2@apache.org wrote on Thu, Jul 25, 2013 at 14:11:59 -0000:
> Author: stefan2
> Date: Thu Jul 25 14:11:59 2013
> New Revision: 1506978
> 
> URL: http://svn.apache.org/r1506978
> Log:
> On the fsfs-improvements branch: enable TxDelta caching by default
> 
> * subversion/libsvn_fs_fs/caching.c
>   (read_config): default to TXDELTA caching option to "true"
> 
> * subversion/svnserve/svnserve.c
>   (svnserve__options): update help string
>   (main): update default value