You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/03/24 00:37:18 UTC
[Impala-ASF-CR] IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18349
Change subject: IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
......................................................................
IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Ranger started pulling in aws-java-sdk-bundle. Impala uses a
stripped down version of this jar (impala-minimal-s3a-aws-sdk)
to save space and we don't need aws-java-sdk-bundle. This adds
an exclusion to ranger-plugins-audit to avoid this dependency.
Testing:
- Ran core tests
Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0
---
M fe/pom.xml
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/18349/1
--
To view, visit http://gerrit.cloudera.org:8080/18349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0
Gerrit-Change-Number: 18349
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18349 )
Change subject: IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7960/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0
Gerrit-Change-Number: 18349
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Mar 2022 00:38:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18349 )
Change subject: IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0
Gerrit-Change-Number: 18349
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Mar 2022 05:04:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18349 )
Change subject: IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
......................................................................
IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Ranger started pulling in aws-java-sdk-bundle. Impala uses a
stripped down version of this jar (impala-minimal-s3a-aws-sdk)
to save space and we don't need aws-java-sdk-bundle. This adds
an exclusion to ranger-plugins-audit to avoid this dependency.
Testing:
- Ran core tests
Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0
Reviewed-on: http://gerrit.cloudera.org:8080/18349
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M fe/pom.xml
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Csaba Ringhofer: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0
Gerrit-Change-Number: 18349
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18349 )
Change subject: IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10330/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0
Gerrit-Change-Number: 18349
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Mar 2022 00:58:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18349 )
Change subject: IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0
Gerrit-Change-Number: 18349
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Mar 2022 10:46:40 +0000
Gerrit-HasComments: No