You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/11 08:12:54 UTC
[GitHub] [apisix] shuaijinchao opened a new pull request #6581: chore: remove redundant semicolons
shuaijinchao opened a new pull request #6581:
URL: https://github.com/apache/apisix/pull/6581
### What this PR does / why we need it:
Remove redundant semicolons
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6581: chore: remove redundant semicolons
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6581:
URL: https://github.com/apache/apisix/pull/6581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6581: chore: remove redundant semicolons
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6581:
URL: https://github.com/apache/apisix/pull/6581#discussion_r825436775
##########
File path: apisix/admin/routes.lua
##########
@@ -285,7 +285,7 @@ function _M.patch(id, conf, sub_path, args)
end
utils.inject_timestamp(node_value, nil, true)
else
- node_value = core.table.merge(node_value, conf);
+ node_value = core.table.merge(node_value, conf)
Review comment:
Here are some ';' I have found with simple regex:
```
./admin/ssl.lua: node_value = core.table.merge(node_value, conf);
./admin/plugin_config.lua: node_value = core.table.merge(node_value, conf);
./admin/services.lua: node_value = core.table.merge(node_value, conf);
./admin/global_rules.lua: node_value = core.table.merge(node_value, conf);
./admin/upstreams.lua: new_value = core.table.merge(new_value, conf);
./plugins/limit-req.lua: key, err, n_resolved = core.utils.resolve_var(conf_key, ctx.var);
./plugins/limit-count.lua: key, err, n_resolved = core.utils.resolve_var(conf_key, ctx.var);
./balancer/chash.lua: chash_key, err, n_resolved = core.utils.resolve_var(key, ctx.var);
./plugins/limit-conn/init.lua: key, err, n_resolved = core.utils.resolve_var(conf_key, ctx.var);
```
Let's remove them too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6581: chore: remove redundant semicolons
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6581:
URL: https://github.com/apache/apisix/pull/6581#discussion_r825435858
##########
File path: apisix/admin/routes.lua
##########
@@ -285,7 +285,7 @@ function _M.patch(id, conf, sub_path, args)
end
utils.inject_timestamp(node_value, nil, true)
else
- node_value = core.table.merge(node_value, conf);
+ node_value = core.table.merge(node_value, conf)
Review comment:
Can we check it in the linter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #6581: chore: remove redundant semicolons
Posted by GitBox <gi...@apache.org>.
shuaijinchao commented on a change in pull request #6581:
URL: https://github.com/apache/apisix/pull/6581#discussion_r825572491
##########
File path: apisix/admin/routes.lua
##########
@@ -285,7 +285,7 @@ function _M.patch(id, conf, sub_path, args)
end
utils.inject_timestamp(node_value, nil, true)
else
- node_value = core.table.merge(node_value, conf);
+ node_value = core.table.merge(node_value, conf)
Review comment:
> Can we check it in the linter?
Great idea, I created an issue #6604 that I will add validation for in the next PR to make lint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org