You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/27 02:58:18 UTC

[GitHub] [apisix] yongboy commented on a change in pull request #3424: fix: when called checker:get_target_status got err, we should log it~

yongboy commented on a change in pull request #3424:
URL: https://github.com/apache/apisix/pull/3424#discussion_r564990661



##########
File path: apisix/balancer.lua
##########
@@ -55,10 +55,12 @@ local function fetch_health_nodes(upstream, checker)
     local port = upstream.checks and upstream.checks.active and upstream.checks.active.port
     local up_nodes = core.table.new(0, #nodes)
     for _, node in ipairs(nodes) do
-        local ok = checker:get_target_status(node.host, port or node.port, host)
+        local ok, err = checker:get_target_status(node.host, port or node.port, host)
         if ok then
             -- TODO filter with metadata
             up_nodes[node.host .. ":" .. node.port] = node.weight
+        elseif err then
+            core.log.error("failed to get health check target status: ", err)

Review comment:
       Copy ~




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org